Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] WELD-2796 Bundle imports for built-in bean proxies #3039

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

Azquelt
Copy link
Contributor

@Azquelt Azquelt commented Aug 23, 2024

When a client proxy is created for a built-in bean, it may be loaded using the classloader of the weld osgi bundle because it provides the built-in bean.

This means that the bundle should import all the packages necessary to load the proxy class, which may include packages that the code in the bundle doesn't directly reference.

The following package imports are added:

  • jakarta.servlet.descriptor (for ServletContext)
  • javax.security.auth (for Principal)

For WELD-2796

When a client proxy is created for a built-in bean, it may be loaded
using the classloader of the weld osgi bundle because it provides the
built-in bean.

This means that the bundle should import all the packages necessary to
load the proxy class, which may include packages that the code in the
bundle doesn't directly reference.

The following package imports are added:
- jakarta.servlet.descriptor (for ServletContext)
- javax.security.auth (for Principal)
@Azquelt Azquelt requested a review from manovotn as a code owner August 23, 2024 13:22
@Azquelt Azquelt changed the title [5.1] Bundle imports for built-in bean proxies [5.1] WELD-2796 Bundle imports for built-in bean proxies Aug 23, 2024
@manovotn manovotn merged commit b4f1fa2 into weld:5.1 Aug 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants