Update game logic and error handling in spiel.py #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit introduces a new function, `get_observation_tensor_shape(game: Game) -> Tuple`, which handles game observation dimensions and improves error handling in this respect. The game in play was switched from tic_tac_toe to backgammon. Moreover, the error handling for the method `self.board.rewards()` was improved to prevent a loss of the entire operation when an exception is catched.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit introduces a new function,
get_observation_tensor_shape(game: Game) -> Tuple, which handles game observation dimensions and improves error handling in this respect. The game in play was switched from tic_tac_toe to backgammon. Moreover, the error handling for the methodself.board.rewards()was improved to prevent a loss of the entire operation when an exception is catched.It fixes the bug mentioned in the issue: #225