Repository navigation
feat(zbugs-gpui): multi-line comments, ⌘Enter, and activity toasts - #156
Merged
Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-cbacad36-05e5-4611-baca-5ce275bfe755 Co-authored-by: tmm <tmm@tmm.dev>
Amp-Thread-ID: https://ampcode.com/threads/T-cbacad36-05e5-4611-baca-5ce275bfe755 Co-authored-by: tmm <tmm@tmm.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More zbugs-gpui parity with the web app:
Confirm { secondary: true }in text fields, which the comment box and gpui-kit's dialogs handle.The macOS e2e now posts its first comment by pressing ⌘Enter in the comment field. I checked the toasts by hand, inserting another user's comment and reaction in Postgres while the issue was open.