Repository navigation
feat(zbugs): app icons with framework badges, and app bundles for the Rust apps - #182
Merged
Merged
Conversation
… Rust apps zbugs-gpui and zbugs-rune ran as bare executables, so the Dock showed the generic "exec" icon. On macOS, `cargo run` now runs each from inside an app bundle (bundle.sh, Cargo's runner there) with an Icon Composer icon compiled by actool: zbugs-swift's icon with GPUI's or Rune's logo as a badge in the bottom-right corner. zbugs-swift's icon gets Swift's logo the same way. Amp-Thread-ID: https://ampcode.com/threads/T-01a1d0e5-95f4-73e5-8d5d-9db8bfed7733 Co-authored-by: tmm <tmm@tmm.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zbugs-gpui and zbugs-rune ran as bare executables, so macOS showed them in the Dock and Finder as the generic black "exec" icon. This gives all three zbugs apps the same Icon Composer icon (zbugs-swift's Zero logo) with the language's or framework's logo as a badge in the bottom-right corner, and runs the two Rust apps as real
.appbundles.AppIcon.iconin each app. The Swift badge is Swift's logo (squircle and bird) from swift.org's site repository. GPUI's is the mark from gpui.rs, white on black. Rune's is the pixel ᚱ from Rune's repository (MIT), blue on black as on Rune's own icon.cargo runinapps/zbugs-gpuiorapps/zbugs-runenow goes throughbundle.sh(Cargo's runner, set in.cargo/config.tomlfor macOS only). The script makesZBugs GPUI.app/ZBugs Rune.appbeside the executable, with the icon compiled byactool, and runs the app from inside it. Environment variables, arguments, and terminal output work as before, and the bundle stays so it can be opened from Finder. Test binaries and Linux are unaffected.bundle.shre-registers the bundle with LaunchServices before launching. Without that, the first launch of a fresh bundle showed a "can't open" overlay in the Dock (reproduced, then fixed).Checked on macOS 26.3 with Xcode 26.1.1:
cargo testin both apps, Rune's headlesscargo run -- --snap(through the bundle), the Swift app'sxcodebuildbuild, and launching each bundle bycargo runand byopen. Before-and-after Dock and Finder screenshots are in the Amp thread.Swift's and GPUI's logos are their owners' trademarks. Apple's Swift logo guidelines cover course materials and technical publications, not app icons. That's fine for these unpublished dev apps, but they should be swapped out before any distribution.