Repository navigation
test(zero-conformance): vectors from the re-baselined restored zql push tests - #198
Merged
Merged
Conversation
…sh tests restored-ivm.test.ts now also runs the re-baselined copies of cap.push, flipped-join.push, flipped-join.more-fetch and take.push from #195, with their own assertions, and records the cases they build. Their 125 cases, less one the chunked flipped-join test builds twice, go to the new vectors/restored-ivm-rebaselined.json: 124 cases, none of which restored-ivm.json has. restored-ivm.json and every other vector file are unchanged. Swift's RestoredIVMTests replays the new file case by case, like restored-ivm.json, and so does Rust's restored suite. Amp-Thread-ID: https://ampcode.com/threads/T-472dde83-243c-421c-b41d-4e7aaf375188 Co-authored-by: tmm <tmm@tmm.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds conformance vectors from the re-baselined push copies in #195. Test-only, so there's no changeset.
restored-ivm.test.tsalso runs the copies ofcap.push,flipped-join.push,flipped-join.more-fetchandtake.push, with their own assertions. It records each case they pass torunPushTestorrunFetchTest.vectors/restored-ivm-rebaselined.json.restored-ivm.jsonand every other vector file stay byte-identical: a fullpnpm run generateadds only the new file.restored-ivm.json. None has the same AST as a case inivm,ivm-featuresorbughunt-ivm.RestoredIVMTestsreplays the new file case by case, likerestored-ivm.json. Rust'srestoredsuite replays it too; otherwise its runner would list the file as unreplayed.Local checks:
zero-conformancecheck mode,check-types, lint,oxfmtandswift format lintpass.