Repository navigation
fix(zbugs-swift): show the issue count in full on iPhone and iPad - #199
Merged
Merged
Conversation
The list's toolbar gave the count a few characters' width, so 16,155 read as "16…". At its fixed size it shows in full; macOS is unchanged. Amp-Thread-ID: https://ampcode.com/threads/T-09cae685-ab24-4553-a84f-3ace30fd7ad4 Co-authored-by: tmm <tmm@tmm.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue list's count now shows in full on iPhone and iPad:
16,155, not16…. macOS is unchanged. zbugs-swift only, so there's no changeset.Cause
On iOS 26, the navigation bar gave the count's toolbar item only a few characters' width and truncated the text, even with lots of free room in the bar. It happened on every launch, cold or warm, so it's not about the count arriving late. The count's text is the same as the web app's (
toLocaleString, or the roundedN+estimate); only its width was wrong.Change
.fixedSize()on the count in the list's toolbar, so the bar lays it out at its full width. Its width now follows the number. Switching from Closed (4,361) to All (20,516) grows the item from 47 to 58 pt.Checks
Local zbugs-swift backend with 20,000 synthetic issues added to the seed (20,516 total, 16,155 open), Xcode 26.1.1, iOS 26.2 simulators. Screenshots are in the Amp thread.
16…on main, from a clean install and again on relaunch.16,155with this change, in both cases.4,361and20,516in full.20…on main,20,516with this change.2,051,600fits next to the other toolbar items.swift format lint --stricton the file.