-
Notifications
You must be signed in to change notification settings - Fork 339
[WV-2287] Moved ManageMyCandidates navigation to ManageMyCandidatesLanding.jsx and UI components to other files [MERGE READY] #4614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…nding.jsx and UI components to other files [TEAM REVIEW]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
| title="Select candidate" | ||
| > | ||
| <ArrowDownIcon fontSize="small" /> | ||
| <PickerMenu role="listbox"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| onSelectFile={handleSelectCSV} | ||
| allColumnsOK={allColumnsOK} | ||
| /> | ||
| <input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
| title="Select candidate" | ||
| > | ||
| <ArrowDownIcon fontSize="small" /> | ||
| <PickerMenu role="listbox"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| <SelectButton type="button" onClick={handleSelectCSV}>Select file</SelectButton> | ||
| </Footer> | ||
|
|
||
| <input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
ManageMyCandidatesLanding.jsx now only contains routing, navigation, and politician state handling between tabs. All other logic like modals, invites, imports, etc is handled in ManageMyCandidates.jsx (soon-to-be ImportInvitePage.jsx) and the four respective modal files.