Simplify wayland configure event #5780
Conversation
Remove the unnecessary PendingEvent struct, and just call functions directly. I think this is easier to reason about, and fits better with the current architecture of SCTK 0.17
There was a problem hiding this comment.
Thanks for this!
On startup, the border frame now matches the window dimensions under weston (which may be a more general side effect of the sctk upgrade, I didn't try to run down when that happened).
However, when I resize the window, it appears to be 1 cell out of sync:
is that something that is logically part of this PR? weston only seems to allow me to resize either horizontally or vertically, so I wonder if this is related to the TODO comment about width+height only triggering some work somehow?
that is definitely not intentional. My commit to handle the case where only one dimension is given doesn't seem to help. I'm not sure what the actual problem is yet. Interstingly, I don't get the same problem if I run it in floating mode in sway, and resize it. I'm not sure what the difference is. Maybe sway doesn't let the client resize the window itself? |
Remove the unnecessary PendingEvent struct, and just call functions directly. I think this is easier to reason about, and fits better with the current architecture of SCTK 0.17