Enhanced vi-like word motions in copy mode #5997
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the code, non_blank_word is a vim WORD, and word is vim word. Added functions for the motions "vB", "vE" and "vW". Since the current implementation of move_to_end_of_word acted as "vE", the new implementation added acts as "ve"
Added 3 new copy-mode assignments: MoveBackwardNonBlankWord -> move vim WORD backward MoveForwardNonBlankWord -> move vim WORD forward MoveForwardNonBlankWordEnd -> move to the end of vim WORD
|
Tested here, and seems to work well. Is a nice addition . +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Item 2 from #4471, which are more complete vi motions. Before the PR, copy-mode already had:
And now it has
In the code, word and WORD are called word and non_blank_word, respectively, since vim's definition of WORD is a sequence of non-blank characters separated by whitespace.
These bindings were manually tested and seem to work as intended, however I thought of adding tests to validate the behavior but found no examples of how to do so, any tips would be greatly appreciated.