Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CSM destinations to CSP Level 3. #1536 #1536

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Update CSM destinations to CSP Level 3. #1536 #1536

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5d5d09a
Update CSM destinations to CSP Level 3.
Nov 12, 2022
c4262a7
Update CSM destination list to CSP level 3.
Nov 14, 2022
3b13140
Update CSM destinations to CSP level 3
Nov 14, 2022
06575c3
Delete PULL_REQUEST_TEMPLATE.md
Nov 14, 2022
f3fd134
revert changing pull request file
Dec 26, 2022
2f3d5b8
Revert "Delete PULL_REQUEST_TEMPLATE.md"
Jan 27, 2023
52a6eab
Merge https://github.com/whatwg/fetch into new_branch
Jan 27, 2023
e7147fb
add changes
Jan 27, 2023
6fbefaf
1536
Jan 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ Thank you for contributing to the Fetch Standard! Please describe the change you
-->

- [ ] At least two implementers are interested (and none opposed):
* …
* …
* … Update CSP destinations to CSP Level 3
* … Change 'style-src' to 'style-src-elem'
ToniWilliams1 marked this conversation as resolved.
Show resolved Hide resolved
- [ ] [Tests](https://github.com/web-platform-tests/wpt) are written and can be reviewed and commented upon at:
* …
- [ ] [Implementation bugs](https://github.com/whatwg/meta/blob/main/MAINTAINERS.md#handling-pull-requests) are filed:
Expand Down
11 changes: 6 additions & 5 deletions fetch.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1654,11 +1654,11 @@ not always relevant and might require different behavior.
<code>cursor</code>, CSS' <code>list-style-image</code>, …
<tr>
<td>"<code>audioworklet</code>"
<td><code>script-src</code>
<td><code>script-src-elem</code>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's list both, separated by a comma. Also, it seems you forgot the script-src for the script element below.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've now listed both style-src and style-src-elem. Also added the script-src for the script element below.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see that reflected when I click on "Files changed" above.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this issue still open?

<td><code>audioWorklet.addModule()</code>
<tr>
<td>"<code>paintworklet</code>"
<td><code>script-src</code>
<td><code>script-src-elem</code>
<td><code>CSS.paintWorklet.addModule()</code>
<tr>
<td>"<code>script</code>"
Expand All @@ -1678,11 +1678,11 @@ not always relevant and might require different behavior.
<td><code>Federated Credential Management requests</code>
<tr>
<td>"<code>worker</code>"
<td><code>child-src</code>, <code>script-src</code>, <code>worker-src</code>
<td><code>worker-src</code>, <code>script-src</code>, <code>worker-src</code>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change. It already lists worker-src and it should continue to list child-src.

<td><code>Worker</code>
<tr>
<td>"<code>style</code>"
<td><code>style-src</code>
<td><code>style-src-elem</code>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's list both here, as with script, separated by a comma.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've now added both style-src and stly-src-elem

<td>HTML's <code>&lt;link rel=stylesheet></code>, CSS' <code>@import</code>
<tr>
<td>"<code>track</code>"
Expand Down Expand Up @@ -1718,7 +1718,7 @@ not always relevant and might require different behavior.
<tr>
<td>"<code>xslt</code>"
<td>"<code>xslt</code>"
<td><code>script-src</code>
<td><code>script-src-elem</code>
<td><code>&lt;?xml-stylesheet></code>
</table>

Expand Down Expand Up @@ -8465,6 +8465,7 @@ Tiancheng "Timothy" Gu,
Tobie Langel,
Tom Schuster,
Tomás Aparicio,
Toni Williams,
triple-underscore<!-- GitHub -->,
保呂毅 (Tsuyoshi Horo),
Tyler Close,
Expand Down