Skip to content

Reference close request steps #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025
Merged

Reference close request steps #226

merged 1 commit into from
Jul 25, 2025

Conversation

domenic
Copy link
Member

@domenic domenic commented Jun 28, 2023

This replaces the vague "If the end user instructs the user agent to end a fullscreen session".

Depends on whatwg/html#9462.


Preview | Diff

@domenic domenic added the do not merge yet Pull request must not be merged per rationale in comment label Jun 28, 2023
@domenic domenic added do not merge yet Pull request must not be merged per rationale in comment and removed do not merge yet Pull request must not be merged per rationale in comment labels Nov 21, 2023
@domenic domenic removed the do not merge yet Pull request must not be merged per rationale in comment label Jul 24, 2025
@domenic
Copy link
Member Author

domenic commented Jul 24, 2025

Oh, this is ready to be reviewed and merged!

@annevk
Copy link
Member

annevk commented Jul 24, 2025

I think you need to rebase and force push to make CI happy.

This replaces the vague "If the end user instructs the user agent to end a fullscreen session".
@domenic domenic changed the title Reference close signal steps Reference close request steps Jul 25, 2025
@domenic domenic merged commit dd2b098 into main Jul 25, 2025
2 checks passed
@domenic domenic deleted the close-signals branch July 25, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants