Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic import maps #10528

Open
wants to merge 50 commits into
base: main
Choose a base branch
from
+416 −83
Open

Dynamic import maps #10528

Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
0a689b6
Enable multiple import maps - resolved module set
yoavweiss Jul 28, 2024
09987d0
Drawing out plans
yoavweiss Jul 28, 2024
8ee8c77
Got a few module resolution changes
yoavweiss Jul 29, 2024
7a39844
Setting the resolved URL on Module Script
yoavweiss Jul 29, 2024
a3d65d8
Made some progress in the merge algo
yoavweiss Jul 29, 2024
8ee2f40
Complete with TODOs
yoavweiss Jul 30, 2024
cb878e8
conformance issues
yoavweiss Jul 30, 2024
03dde71
moar conformance fixes
yoavweiss Jul 30, 2024
c19c162
Ensure that the importmap validation in "create a JS module script" m…
yoavweiss Jul 30, 2024
2b676c1
Fix linking to set iterate and remove
yoavweiss Jul 30, 2024
a529f0f
Address some review comments
yoavweiss Aug 1, 2024
c10c394
A few more review comments
yoavweiss Aug 1, 2024
58adb96
Add examples
yoavweiss Aug 1, 2024
2b4ec95
Fix up conformance issue
yoavweiss Aug 1, 2024
ce6cd84
Fix up algorithm phrasing
yoavweiss Aug 1, 2024
c1f51c7
More review comment fixes
yoavweiss Aug 2, 2024
31259c2
Fix up the merge algorithm and add integrity handling
yoavweiss Aug 2, 2024
efa2a17
Fixed integrity map threading
yoavweiss Aug 2, 2024
89c0ead
Remove no longer needed assert
yoavweiss Aug 2, 2024
445efe3
More review comments
yoavweiss Aug 5, 2024
e4e17bb
Revert the HostGetImportMetaProperties changes
yoavweiss Aug 5, 2024
55e33ed
Modified algorithms
yoavweiss Aug 5, 2024
1da6e1f
Pass importMap to fetch descendants
yoavweiss Aug 5, 2024
2a4f74e
No optional import maps
yoavweiss Aug 6, 2024
d14a76f
Avoid mutating newImportMap
yoavweiss Aug 6, 2024
3df7f97
do not add the module from an inline module graph. fix typo
yoavweiss Aug 8, 2024
c8e941d
Revert calls to settingsObject
yoavweiss Aug 30, 2024
2d1dde2
Remove asserts
yoavweiss Aug 30, 2024
dd0f028
More review comments
yoavweiss Aug 30, 2024
eba84fc
revamped the merge algo
yoavweiss Sep 2, 2024
98df252
Revamp fix ups
yoavweiss Sep 2, 2024
fbd3d02
Address a couple more review comments
yoavweiss Sep 2, 2024
fef0c34
Ensure prefix and specifier are normalized RE the resolved set
yoavweiss Sep 2, 2024
3803605
Remove TODO
yoavweiss Sep 2, 2024
1bedea3
Tighten up the add module to resolve module set algorithm
yoavweiss Sep 3, 2024
30b5470
Move no-longer-relevant comment
yoavweiss Sep 3, 2024
6621061
clean up the merge algo
yoavweiss Sep 3, 2024
83269e7
Modify example and address prefix conflicts
yoavweiss Sep 9, 2024
d92f5c1
Remove rebase leftovers
yoavweiss Sep 9, 2024
49ca26e
Remove more leftovers
yoavweiss Sep 9, 2024
a0f936b
Move specifier prefixes above referring URL check
yoavweiss Sep 10, 2024
3b58fbb
Add examples to cover exact match and all impacting rules
yoavweiss Sep 10, 2024
37f36c5
Add dev console logs
yoavweiss Sep 10, 2024
35369cf
Add more console warnings
yoavweiss Sep 11, 2024
c8694e3
Stop piping through the import map
yoavweiss Sep 12, 2024
852dbaa
Call the prefixes on scope rules as well
yoavweiss Sep 12, 2024
39551fc
Only bail after prefixes
yoavweiss Sep 12, 2024
b6b5485
Deoptimize the algorithm
yoavweiss Sep 16, 2024
ee1ef00
Add note
yoavweiss Sep 17, 2024
b0bbba7
Remove find url prefixes
yoavweiss Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading