Editorial: Add a missing comma #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saschanaz
commented
Apr 4, 2024
| @@ -451,7 +451,7 @@ interpreted as a language tag. Validity or well-formedness are not enforced. [[! | |||
|
|
|||
| <ol> | |||
| <li><p>Wait for any <a for=/ lt=fetch>fetches</a> to complete and <var>notification</var>'s | |||
There was a problem hiding this comment.
Out of scope of this PR: This effectively is await-ing the fetch steps in bad way; the fetch steps say the resources are set only when supported but here we are waiting for those resources to be set.
Is there a better wait to wait for a parallel task? 🤔
There was a problem hiding this comment.
I think we should probably set "image resource" either way (to a decoded resource or to failure or some such). And then we wait for it to not be in its initial state (null?).
annevk
approved these changes
Apr 4, 2024
| @@ -451,7 +451,7 @@ interpreted as a language tag. Validity or well-formedness are not enforced. [[! | |||
|
|
|||
| <ol> | |||
| <li><p>Wait for any <a for=/ lt=fetch>fetches</a> to complete and <var>notification</var>'s | |||
There was a problem hiding this comment.
I think we should probably set "image resource" either way (to a decoded resource or to failure or some such). And then we wait for it to not be in its initial state (null?).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff