Clean up some parts of object creation #663
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Either the object being created is an ordinary object (and follows the rules for it), or we now specify the internal slots of the exotic objects. Addresses part of whatwg#655 that have to do with reducing "unless otherwise specified" clauses.
TimothyGu
force-pushed
the
creation-cleanup
branch
from
759555c
to
2eb3347
Compare
|
Note tc39/ecma262#1460 |
|
@TimothyGu do you still want to pursue this? |
|
This could probably be cleaned up a bit, but I think it's still applicable. |
|
Some of this was done in #871 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #655 that have to do with reducing "unless otherwise specified" clauses, by making things more explicit. It doesn't touch the assignment of internal methods, which is being discussed.
Preview | Diff