core: decode roomName doAppStart - #1038
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 6be9bc2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sarahrose-ferris
force-pushed
the
sarahrose/PAN-2678-roomurl-decoding
branch
from
June 16, 2026 11:29
e7d8dc3 to
5aa954e
Compare
Contributor
Author
|
/canary |
Contributor
|
🚀 The canary releases have been published to npm. You can test the releases by installing the newly published versions: pnpm add @whereby.com/assistant-sdk@0.0.0-canary-20260616113857pnpm add @whereby.com/browser-sdk@0.0.0-canary-20260616113857pnpm add @whereby.com/core@0.0.0-canary-20260616113857pnpm add @whereby.com/react-native-sdk@0.0.0-canary-20260616113857 |
sarahrose-ferris
force-pushed
the
sarahrose/PAN-2678-roomurl-decoding
branch
from
June 16, 2026 11:56
5aa954e to
f7a8b71
Compare
Contributor
Author
|
/canary |
Contributor
|
🚀 The canary releases have been published to npm. You can test the releases by installing the newly published versions: pnpm add @whereby.com/assistant-sdk@0.0.0-canary-20260616120149pnpm add @whereby.com/browser-sdk@0.0.0-canary-20260616120149pnpm add @whereby.com/core@0.0.0-canary-20260616120149pnpm add @whereby.com/react-native-sdk@0.0.0-canary-20260616120149 |
sarahrose-ferris
changed the title
sarahrose-ferris
force-pushed
the
sarahrose/PAN-2678-roomurl-decoding
branch
from
June 17, 2026 09:36
f7a8b71 to
666c68b
Compare
sarahrose-ferris
changed the title
Contributor
Author
|
/canary |
Contributor
|
🚀 The canary releases have been published to npm. You can test the releases by installing the newly published versions: pnpm add @whereby.com/assistant-sdk@0.0.0-canary-20260617094509pnpm add @whereby.com/browser-sdk@0.0.0-canary-20260617094509pnpm add @whereby.com/core@0.0.0-canary-20260617094509pnpm add @whereby.com/react-native-sdk@0.0.0-canary-20260617094509 |
sarahrose-ferris
changed the title
sarahrose-ferris
force-pushed
the
sarahrose/PAN-2678-roomurl-decoding
branch
from
June 18, 2026 12:19
666c68b to
2d0c47e
Compare
Contributor
Author
|
/canary |
Contributor
|
🚀 The canary releases have been published to npm. You can test the releases by installing the newly published versions: pnpm add @whereby.com/assistant-sdk@0.0.0-canary-20260618122331pnpm add @whereby.com/browser-sdk@0.0.0-canary-20260618122331pnpm add @whereby.com/core@0.0.0-canary-20260618122331pnpm add @whereby.com/react-native-sdk@0.0.0-canary-20260618122331 |
sarahrose-ferris
force-pushed
the
sarahrose/PAN-2678-roomurl-decoding
branch
from
June 18, 2026 12:56
2d0c47e to
6fd4160
Compare
richtrwhereby
approved these changes
Jun 23, 2026
sarahrose-ferris
force-pushed
the
sarahrose/PAN-2678-roomurl-decoding
branch
from
June 23, 2026 14:53
6fd4160 to
6be9bc2
Compare
sarahrose-ferris
changed the title
Contributor
Author
|
/canary |
Contributor
|
🚀 The canary releases have been published to npm. You can test the releases by installing the newly published versions: pnpm add @whereby.com/assistant-sdk@0.0.0-canary-20260623145732pnpm add @whereby.com/browser-sdk@0.0.0-canary-20260623145732pnpm add @whereby.com/core@0.0.0-canary-20260623145732pnpm add @whereby.com/react-native-sdk@0.0.0-canary-20260623145732 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary:
In order to support rooms with special characters in the name, we need to do some decoding on
roomUrl. This prevents clients trying to join rooms with the encoded URL, which technically is a non-existing room.Related Issue:
Testing
Test instructions here: https://github.com/whereby/recording-service/pull/1096
Screenshots/GIFs (if applicable)
Checklist
under the terms of the MIT license.
Additional Information