fix: Remove unnecessary airflow files #106
Conversation
|
Review these changes at https://app.gitnotebooks.com/wherobots/wherobots-examples/pull/106 |
There was a problem hiding this comment.
Pull request overview
This PR simplifies a GitHub Actions workflow by removing AWS S3 integration and refocusing it solely on converting notebooks to Python scripts and updating a Git tag. The workflow file has been renamed to reflect this new purpose, eliminating unnecessary complexity related to Airflow integration testing that was abandoned.
Key Changes:
- Renamed workflow file from
upload-notebook-to-s3.ymltoupload-notebook-to-git-tag.yml - Removed all AWS credential configuration and S3 upload steps for both staging and production environments
- Removed
id-token: writepermission that was required for AWS authentication
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This pull request updates the GitHub Actions workflow responsible for converting notebooks to Python scripts. The main change is that the workflow no longer uploads the converted scripts to AWS S3, and instead focuses solely on the conversion and updating a Git tag. The workflow file has also been renamed to better reflect its new purpose.
Workflow simplification and focus:
.github/workflows/upload-notebook-to-s3.ymlto.github/workflows/upload-notebook-to-git-tag.yml, and all references to uploading notebooks to S3 were removed to reflect the new focus on converting notebooks and updating a Git tag.Furqaan was using airflow initially for integration tests but later decided to give up. But the code was left uncleaned.