PR triage: merge 5 upstream PRs with test coverage

.github/workflows/ci.yml

@@ -23,6 +23,24 @@ jobs:
       - name: Build
         run: go build -v ./...
 
+  lint:
+    name: Lint
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Set up Go
+        uses: actions/setup-go@v5
+        with:
+          go-version: '1.25'
+          cache: true
+
+      - name: Run golangci-lint
+        uses: golangci/golangci-lint-action@v7
+        with:
+          version: v2.8.0
+
   unit-tests:
     name: Unit Tests
     runs-on: ubuntu-latest
@@ -40,6 +58,8 @@ jobs:
         run: sudo apt-get update && sudo apt-get install -y tmux
 
       - name: Run unit tests with coverage
+        env:
+          TMUX_TESTS: "1"
         run: |
           go test -coverprofile=coverage.out -covermode=atomic ./internal/... ./pkg/...
           go tool cover -func=coverage.out
@@ -69,6 +89,8 @@ jobs:
         run: sudo apt-get update && sudo apt-get install -y tmux
 
       - name: Check coverage thresholds
+        env:
+          TMUX_TESTS: "1"
         run: |
           go test -coverprofile=coverage.out -covermode=atomic ./internal/... ./pkg/...
 
@@ -113,6 +135,14 @@ jobs:
           git config --global user.email "ci@github.com"
           git config --global user.name "GitHub CI"
 
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+
+      - name: Install Claude CLI
+        run: npm install -g @anthropic-ai/claude-code
+
       - name: Run e2e tests
         run: go test -v ./test/...
 

.golangci.yml

@@ -0,0 +1,100 @@
+version: "2"
+
+linters:
+  default: standard
+  enable:
+    - gocritic
+    - misspell
+  settings:
+    errcheck:
+      # Don't check type assertions (too noisy for map access patterns)
+      check-type-assertions: false
+      # Exclude common patterns where ignoring errors is acceptable
+      exclude-functions:
+        # File operations that are safe to ignore in defer
+        - (io.Closer).Close
+        - (*os.File).Close
+        - (net.Conn).Close
+        - (net.Listener).Close
+        - (*net.UnixConn).Close
+        - (*net.UnixListener).Close
+        # Exec commands in cleanup contexts
+        - (*os/exec.Cmd).Run
+        # Printf-like functions where errors are typically ignored
+        - (*github.com/fatih/color.Color).Printf
+        - (*github.com/fatih/color.Color).Print
+        - fmt.Printf
+        - fmt.Println
+        - fmt.Print
+        - fmt.Scanln
+        - fmt.Sscanf
+        # JSON encoding where error handling is optional
+        - (*encoding/json.Encoder).Encode
+        # OS operations that are best-effort cleanup
+        - os.Remove
+        - os.RemoveAll
+        - os.Setenv
+        - os.Unsetenv
+        - os.Chdir
+        - os.Chmod
+        - os.MkdirAll
+        - os.WriteFile
+        # Daemon/server stop operations in cleanup
+        - (*github.com/dlorenc/multiclaude/internal/daemon.Daemon).Stop
+        - (*github.com/dlorenc/multiclaude/internal/daemon.Daemon).Start
+        # Tmux cleanup operations
+        - (*github.com/dlorenc/multiclaude/pkg/tmux.Client).KillSession
+        - (*github.com/dlorenc/multiclaude/pkg/tmux.Client).KillWindow
+        - (*github.com/dlorenc/multiclaude/pkg/tmux.Client).SendKeysLiteral
+        # State operations that are often best-effort
+        - (*github.com/dlorenc/multiclaude/internal/state.State).AddRepo
+        - (*github.com/dlorenc/multiclaude/internal/state.State).AddAgent
+        - (*github.com/dlorenc/multiclaude/internal/state.State).RemoveAgent
+        - (*github.com/dlorenc/multiclaude/internal/state.State).UpdateAgent
+        - (*github.com/dlorenc/multiclaude/internal/state.State).ClearAllAgents
+        - (*github.com/dlorenc/multiclaude/internal/state.State).Save
+        - (*github.com/dlorenc/multiclaude/internal/state.State).SetCurrentRepo
+        # Worktree removal in cleanup
+        - (*github.com/dlorenc/multiclaude/internal/worktree.Manager).Remove
+        # CLI operations in tests
+        - (*github.com/dlorenc/multiclaude/internal/cli.CLI).Execute
+        - (*github.com/dlorenc/multiclaude/internal/cli.CLI).showVersion
+        - (*github.com/dlorenc/multiclaude/internal/cli.CLI).showHelp
+        # Socket server cleanup
+        - (*github.com/dlorenc/multiclaude/internal/socket.Server).Stop
+        - (*github.com/dlorenc/multiclaude/internal/socket.Server).Serve
+        # Logger cleanup
+        - (*github.com/dlorenc/multiclaude/internal/logging.Logger).Close
+    gocritic:
+      disabled-checks:
+        # Allow if-else chains for simple conditions
+        - ifElseChain
+        # Allow deprecation comments in various formats
+        - deprecatedComment
+        # Allow else { if } patterns in some cases
+        - elseif
+    staticcheck:
+      checks:
+        - all
+        # Disable strict style checks
+        - -ST1000  # Package comments - not critical for internal packages
+        - -ST1020  # Method comment form - too strict
+        - -ST1021  # Type comment form - too strict
+        - -ST1022  # Const comment form - too strict
+        - -QF1003  # Don't require tagged switch
+        - -SA9003  # Empty branches are intentional for error handling
+        - -QF1012  # Allow WriteString with fmt.Sprintf (more readable)
+
+formatters:
+  enable:
+    - gofmt
+
+issues:
+  # Show all issues from a linter
+  max-issues-per-linter: 0
+  # Show all issues with the same text
+  max-same-issues: 0
+
+run:
+  timeout: 5m
+  tests: true

.multiclaude/REVIEWER.md

@@ -9,7 +9,7 @@ After every 4-5 PRs have been merged, spawn the following maintenance agents:
 Spawn a worker to look for opportunities to refactor and simplify the codebase:
 
 ```bash
-multiclaude work "Review the codebase for refactoring opportunities: look for duplicated code, overly complex functions, unused code, and areas that could be simplified. Create a PR with any improvements found. Focus on small, safe changes that improve readability and maintainability without changing behavior."
+multiclaude worker create "Review the codebase for refactoring opportunities: look for duplicated code, overly complex functions, unused code, and areas that could be simplified. Create a PR with any improvements found. Focus on small, safe changes that improve readability and maintainability without changing behavior."
 ```
 
 **Focus areas:**
@@ -24,7 +24,7 @@ multiclaude work "Review the codebase for refactoring opportunities: look for du
 Spawn a worker to check test coverage and fill gaps:
 
 ```bash
-multiclaude work "Analyze test coverage across the codebase. Run 'go test -coverprofile=coverage.out ./...' to identify packages with low coverage. Add tests for uncovered or under-tested code paths, prioritizing critical business logic and error handling. Create a PR with the new tests."
+multiclaude worker create "Analyze test coverage across the codebase. Run 'go test -coverprofile=coverage.out ./...' to identify packages with low coverage. Add tests for uncovered or under-tested code paths, prioritizing critical business logic and error handling. Create a PR with the new tests."
 ```
 
 **Focus areas:**

ARCHITECTURE.md

@@ -281,22 +281,49 @@ The CLI handles user commands and communicates with the daemon.
 **Command Tree:**
 ```
 multiclaude
-├── start                    # Start daemon
+├── start                    # Start daemon (alias for daemon start)
 ├── stop-all [--clean]       # Stop everything
-├── init <url>               # Initialize repo
-├── list                     # List repos
-├── work <task>              # Create worker
+├── repo
+│   ├── init <url>           # Initialize repo
+│   ├── list                 # List repos
+│   ├── rm <name>            # Remove repo
+│   ├── use <name>           # Set default repo
+│   ├── current              # Show default repo
+│   ├── unset                # Clear default repo
+│   └── history              # Show task history
+├── worker
+│   ├── create <task>        # Create worker
 │   ├── list                 # List workers
 │   └── rm <name>            # Remove worker
+├── workspace
+│   ├── add <name>           # Add workspace
+│   ├── list                 # List workspaces
+│   ├── connect <name>       # Connect to workspace
+│   └── rm <name>            # Remove workspace
 ├── agent
-│   ├── send-message <to> <msg>
-│   ├── list-messages
-│   ├── read-message <id>
-│   ├── ack-message <id>
-│   └── complete
-├── attach <name>            # Attach to tmux window
+│   ├── attach <name>        # Attach to tmux window
+│   ├── complete             # Signal completion
+│   ├── restart <name>       # Restart crashed agent
+│   ├── send-message         # (alias for message send)
+│   ├── list-messages        # (alias for message list)
+│   ├── read-message         # (alias for message read)
+│   └── ack-message          # (alias for message ack)
+├── message
+│   ├── send <to> <msg>      # Send message
+│   ├── list                 # List messages
+│   ├── read <id>            # Read message
+│   └── ack <id>             # Acknowledge message
+├── agents
+│   ├── list                 # List agent definitions
+│   ├── spawn                # Spawn from prompt file
+│   └── reset                # Reset to defaults
 ├── cleanup [--dry-run]      # Clean orphaned resources
 ├── repair                   # Fix state
+├── review <pr-url>          # Spawn review agent
+├── config                   # View/modify repo config
+├── logs                     # View agent logs
+├── bug                      # Generate diagnostic report
+├── version                  # Show version
 └── daemon
     ├── start
     ├── stop
@@ -309,7 +336,7 @@ multiclaude
 ### Repository Initialization
 
 ```
-User: multiclaude init https://github.com/org/repo
+User: multiclaude repo init https://github.com/org/repo
 
 CLI                          Daemon                       System
  │                              │                            │
@@ -339,7 +366,7 @@ CLI                          Daemon                       System
 ### Worker Creation
 
 ```
-User: multiclaude work "Add unit tests"
+User: multiclaude worker create "Add unit tests"
 
 CLI                          Daemon                       System
  │                              │                            │
@@ -360,7 +387,7 @@ CLI                          Daemon                       System
 ### Message Delivery
 
 ```
-Agent A: multiclaude agent send-message agent-b "Hello"
+Agent A: multiclaude message send agent-b "Hello"
 
 CLI                          Daemon                       System
  │                              │                            │