docs update code success #900
Open
+196
−197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iisakkirotko
requested changes
Dec 6, 2024
Comment on lines
21
to
23
| dense, set_dense = solara.use_state(False) | ||
| outlined, set_outlined = solara.use_state(True) | ||
| text, set_text = solara.use_state(True) |
maartenbreddels
force-pushed
the
master
branch
2 times, most recently
from
cded5b2 to
32af76f
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
iisakkirotko
force-pushed
the
docs_update_code_success
branch
from
8735a83 to
2d0e66c
Compare
for more information, see https://pre-commit.ci
iisakkirotko
requested changes
Dec 30, 2024
Comment on lines
32
to
35
| text=text, | ||
| dense=dense, | ||
| outlined=outlined, | ||
| icon=icon, |
There was a problem hiding this comment.
Also here
Suggested change
| text=text, | |
| dense=dense, | |
| outlined=outlined, | |
| icon=icon, | |
| text=text.value, | |
| dense=dense.value, | |
| outlined=outlined.value, | |
| icon=icon.value, |
| solara.Checkbox(label="Show as text", value=text) | ||
| solara.Checkbox(label="Show outlined", value=outlined) | ||
| solara.Success( | ||
| f"This is solara.Success(label='...', text={text}, dense={dense}, outlined={outlined}, icon={icon})", |
There was a problem hiding this comment.
We should use the .values here instead of the reactives
Suggested change
| f"This is solara.Success(label='...', text={text}, dense={dense}, outlined={outlined}, icon={icon})", | |
| f"This is solara.Success(label='...', text={text.value}, dense={dense.value}, outlined={outlined.value}, icon={icon.value})", |
There was a problem hiding this comment.
Thank you! I already fixed it. If there is any issues, please let me know.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
iisakkirotko
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Looks good other than the unrelated changes. I can clean those up unless you specifically want to @lizzy985.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.