Skip to content

Bug fix: Possible solution for accurate title text on Donation Reminder #6149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Bug fix: Possible solution for accurate title text on Donation Reminder #6149

wants to merge 5 commits into from

Conversation

@Williamrai
Copy link
Collaborator

@Williamrai Williamrai commented Nov 25, 2025

What does this do?

  • adds a new variable continuousArticleVisit for tracking continuous article visit per milestone
  • extract logic from shouldShowReminderNow() to a new function recordReminderShown() which will be called after UI has updated
  • update logic to show accurate titleText

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cooltey cooltey Awaiting requested review from cooltey cooltey is a code owner

@dbrant dbrant Awaiting requested review from dbrant dbrant is a code owner

Assignees

No one assigned

Labels

Bug Bug DO NOT MERGE Do not merge Ready for Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Williamrai