Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFCORE-6779 Replace PersistentResourceXMLDescription with more robust API #6261

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

pferraro
Copy link
Contributor

@pferraro pferraro commented Nov 26, 2024

https://issues.redhat.com/browse/WFCORE-6779

Feature set includes everything from PersistentResourceXMLDescription, plus:

  • Better support for non-default stability-levels
  • More intuitive implementation, including consistent entry/exit criteria for reader/writer methods
  • Correct XML namespace/prefix support
  • Support for (and strict enforcement of) element and element group cardinality during parsing
  • Support for override resource registrations, e.g. /name=*, /name=value1, /name=value2, etc.
  • Support for (and strict enforcement of) xs:choice, xs:sequence, and xs:all semantics.
  • Explicit element content definition (via xs:choice, xs:sequence, or xs:all).
  • Better operation manipulation capability
  • Improved attribute/element name and parser/marshaller overrides for legacy schema versions

N.B. This proposed change no longer attempts to reimplement PersistentResourceXMLDescription using the new implementation, as this is made impossible (without degrading existing schema validation logic) by existing illegal subsystem schemas (see WFLY-20446 and WFCORE-7181). Instead, PersistentSubsystemSchema now extends SubsystemResourceXMLSchema by adapting the PersistentResourceXMLDescription for the subsystem resource to a SubsystemResourceXMLElement.

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@pferraro pferraro marked this pull request as ready for review December 11, 2024 22:32
@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@pferraro pferraro force-pushed the WFCORE-6779 branch 4 times, most recently from 1e382f9 to 1ddc349 Compare March 9, 2025 17:19
@wildfly wildfly deleted a comment from wildfly-ci Mar 9, 2025
@wildfly wildfly deleted a comment from wildfly-ci Mar 9, 2025
@wildfly wildfly deleted a comment from wildfly-ci Mar 9, 2025
@wildfly wildfly deleted a comment from wildfly-ci Mar 9, 2025
@wildfly wildfly deleted a comment from wildfly-ci Mar 9, 2025
@wildfly wildfly deleted a comment from wildfly-ci Mar 9, 2025
@wildfly-ci

This comment was marked as off-topic.

@wildfly-ci

This comment was marked as off-topic.

@wildfly-ci

This comment was marked as off-topic.

@wildfly-ci
Copy link

Core -> Full Integration Build 14640 outcome was FAILURE using a merge of 9981142
Summary: Tests failed: 1 (1 new), passed: 8148, ignored: 109 Build time: 04:08:43

Failed tests

org.wildfly.test.integration.microprofile.faulttolerance.opentelemetry.FaultToleranceOpenTelemetryIntegrationTestCase(standalone-enabled-expansion-test).test: java.lang.AssertionError: expected:<10.0> but was:<4.0>
	at org.wildfly.test.integration.microprofile.faulttolerance.opentelemetry.FaultToleranceOpenTelemetryIntegrationTestCase.lambda$test$5(FaultToleranceOpenTelemetryIntegrationTestCase.java:84)
	at org.jboss.as.test.shared.observability.containers.OpenTelemetryCollectorContainer.assertMetrics(OpenTelemetryCollectorContainer.java:166)
	at org.wildfly.test.integration.microprofile.faulttolerance.opentelemetry.FaultToleranceOpenTelemetryIntegrationTestCase.test(FaultToleranceOpenTelemetryIntegrationTestCase.java:78)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
------- Stdout: -------
 [0m19:46:19,585 INFO  [org.jboss.modules] (main) JBoss Modules version 2.1.6.Final
 [0m [0m19:46:19,987 INFO  [org.jboss.msc] (main) JBoss MSC version 1.5.5.Final
 [0m [0m19:46:19,995 INFO  [org.jboss.threads] (main) JBoss Threads version 2.4.0.Final
 [0m [0m19:46:20,104 INFO  [org.jboss.as] (MSC service thread 1-1) WFLYSRV0049: WildFly 36.0.0.Beta1-SNAPSHOT (WildFly Core 28.0.0.Beta5-SNAPSHOT) starting
 [0m [0m19:46:21,157 INFO  [org.wildfly.security] (Controller Boot Thread) ELY00001: WildFly Elytron version 2.6.1.Final
 [0m [0m19:46:21,848 INFO  [org.jboss.as.server] (Controller Boot Thread) WFLYSRV0039: Creating http management service using socket-binding (management-http)
 [0m [0m19:46:21,861 INFO  [org.xnio] (MSC service thread 1-5) XNIO version 3.8.16.Final
 [0m [0m19:46:21,870 INFO  [org.xnio.nio] (MSC service thread 1-5) XNIO NIO Implementation Version 3.8.16.Final
 [0m [0m19:46:21,902 INFO  [org.jboss.remoting] (MSC service thread 1-2) JBoss Remoting version 5.0.30.Final
 [0m [0m19:46:21,973 INFO  [org.jboss.as.connector.subsystems.datasources] (ServerService Thread Pool -- 49) WFLYJCA0004: Deploying JDBC-compliant driver class org.h2.Driver (version 2.2)


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants