Skip to content

Conversation

@WhittlesJr
Copy link

@WhittlesJr WhittlesJr commented Sep 19, 2019

I'm attempting to use spec-coerce as the backend for cyrus-config: dryewo/cyrus-config#2

During the process, I found a few conversions that I expected to work but didn't, namely:

int? -> double? (remains an int, and thus fails coerce!)
any? -> string? (no string? handler existed yet)
symbol? -> keyword? (can be done by simply calling keyword on it.)

Resolves #25 and then some

@wilkerlucio
Copy link
Owner

Thanks, looks nice, can you please add tests covering the new behavior?

@WhittlesJr
Copy link
Author

Sure! Is this sufficient?

@wilkerlucio
Copy link
Owner

Sure

@wilkerlucio wilkerlucio merged commit 1546a78 into wilkerlucio:master Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

parse-long and parse-double should cast numeric types

2 participants