Runs page redesign #7873
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -260,6 +260,6 @@ | |
| } as any) | ||
| </script> | ||
|
|
||
| <div class="relative h-44"> | ||
| <Line {data} {options} /> | ||
| </div> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| <script lang="ts"> | ||
| type Item = { | ||
| label: string | ||
| icon?: any | ||
| right?: string | ||
| onClick?: () => void | ||
| onHover?: (hover: boolean) => void | ||
| } | ||
| export type Props = { | ||
| closeCallback?: () => void | ||
| items: Item[] | ||
| } | ||
| let { items, closeCallback }: Props = $props() | ||
| </script> | ||
|
|
||
| <ul class="bg-surface-tertiary rounded-md border w-56 relative drop-shadow-base"> | ||
| {#each items as item} | ||
| <li class="w-full"> | ||
| <button | ||
| class="px-3 h-9 text-xs cursor-pointer hover:bg-surface-hover font-normal w-full text-left flex items-center gap-2.5" | ||
| onclick={() => { | ||
| item.onClick?.() | ||
| item.onHover?.(false) | ||
| closeCallback?.() | ||
| }} | ||
| onmouseenter={() => item.onHover?.(true)} | ||
| onmouseleave={() => item.onHover?.(false)} | ||
| > | ||
| {#if item.icon} | ||
| <item.icon size="16"></item.icon> | ||
| {/if} | ||
| <span class="flex-1"> | ||
| {item.label} | ||
| </span> | ||
| {#if item.right} | ||
| <span class="text-xs text-hint">{item.right}</span> | ||
| {/if} | ||
| </button> | ||
| </li> | ||
| {/each} | ||
| {#if items.length === 0} | ||
| <li class="w-full"> | ||
| <div | ||
| class="px-3 h-9 text-xs font-normal w-full text-left flex items-center gap-2.5 text-hint" | ||
| > | ||
| No actions available | ||
| </div> | ||
| </li> | ||
| {/if} | ||
| </ul> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| <script lang="ts"> | ||
| import { clickOutside } from '$lib/utils' | ||
| import { fly } from 'svelte/transition' | ||
| import Portal from './Portal.svelte' | ||
| import type { Snippet } from 'svelte' | ||
|
|
||
| type Props = { | ||
| children: Snippet | ||
| } | ||
|
|
||
| const { children }: Props = $props() | ||
|
|
||
| let _isOpen = $state(false) | ||
| let mousePos = $state({ x: 0, y: 0 }) | ||
| export function open(e: MouseEvent) { | ||
| e.preventDefault() | ||
| _isOpen = true | ||
| mousePos = { x: e.clientX, y: e.clientY } | ||
| console.log('Opening popover at', mousePos) | ||
diegoimbert marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } | ||
| export function close() { | ||
| _isOpen = false | ||
| } | ||
| export function isOpen() { | ||
| return _isOpen | ||
| } | ||
| </script> | ||
|
|
||
| <Portal> | ||
| {#if _isOpen} | ||
| <div | ||
| in:fly={{ x: 0, y: -10, duration: 120 }} | ||
| use:clickOutside={{ | ||
| onClickOutside: (e) => { | ||
| _isOpen = false | ||
| e.preventDefault() | ||
| e.stopPropagation() | ||
|
Comment on lines
+34
to
+37
Contributor
There was a problem hiding this comment. Calling |
||
| } | ||
| }} | ||
| class="absolute left-0 top-0 z-[9999] w-fit" | ||
| style="transform: translate({mousePos.x + 2}px, {mousePos.y + 2}px)" | ||
|
Contributor
There was a problem hiding this comment. The popover is positioned using |
||
| > | ||
| {@render children()} | ||
| </div> | ||
| {/if} | ||
| </Portal> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
icontype isany— consider typing this more specifically (e.g.,typeof import('lucide-svelte').IconorComponent) for better type safety and IDE support.