Simon/feat/process welcome#2365
Draft
SimonThormeyer wants to merge 3 commits into
Draft
Conversation
…on<_>>` Returning `None` is just more appropiate than returning a `ConversationNotFound` error
We don't always want to return an error when a conversation with a given id doesn't exist.
SimonThormeyer
force-pushed
the
simon/feat/process-welcome
branch
from
July 23, 2026 09:28
1c6dd0e to
50512c8
Compare
coriolinus
approved these changes
Jul 23, 2026
istankovic
reviewed
Jul 23, 2026
| // If the conversation exists locally as a pending conversation or as a conversation with epoch 0, we can clear | ||
| // it and keep the one we just created, because this will lead to the desired state, compatible with what we had | ||
| // locally. A fresh group with this `id`, just not created by us. | ||
| // This resolves WPB-21116. |
Member
There was a problem hiding this comment.
It is not clear to me that this is the best solution for WPB-21116, in part because it is unclear how exactly the problem arises. So I would prefer to not proceed with this until we get more clarity on the original issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.