chore: add THIRD PARTY NOTICE - WPB-25975 - #2506
Open
marcoconti83 wants to merge 2 commits into
Open
Conversation
Member
|
How is the THIRD PARTY NOTICE updated when we add/remove a dependency? |
coriolinus
approved these changes
Aug 27, 2026
coriolinus
left a comment
coriolinus
left a comment
Contributor
There was a problem hiding this comment.
The files are fine, but how do we run the internal tool in CI to keep this up to date?
istankovic
requested changes
Aug 27, 2026
istankovic
left a comment
istankovic
left a comment
Member
There was a problem hiding this comment.
I don't think we should do it this way -- third party notices content should not be commited to the repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Adding a THIRD PARTY NOTICES file. This was generated with an internal tool, that requires a bit of per-project customization. I'm also committing the per-project configuration file for that tool.