chore: speed up slow tests [WPB-28455] - #2564
Open
coriolinus wants to merge 8 commits into
Open
Conversation
We haven't enforced the 1-second restriction for some time; remove stale docs references claiming the restriction still exists.
We used to have a restriction that we couldn't add credentials too fast. That hasn't been active for some time now. This removes old delays from tests which were intended to comply with that restriction.
Prior to this change, every pair of members called `can_talk`, which tests bidirectional functionality, starting from both directions. With this change, it only tests starting from one (arbitrary) direction. This should be ok becasue both directions of communication are tested within `can_talk` anyway.
They just load the composite schema directly, which is substantially faster. This is fine because an in-memory database cannot have existing prior state. There are technically some failure modes: exporting a DB in memory and then exporting a copy produces a DB which cannot be opened, because in-memory databases are not encrypted and the export is expected to be encrypted. But that already wouldn't work. Likewise if we did DDL in a meta-migration at some point in the future. that would be invisible to `compile-schema`, and in-memory databases would not see that DDL. But we're not going to do that because of a project convention that meta-migrations are to be used only when necessary, only when something cannot be accomplished in the course of a normal migraiton.
Specifically, all tests creating 5 or more sessions now do so in memory, reducing the amount of wall-clock time which was spent redoing migrations for each session.
coriolinus
force-pushed
the
prgn/chore/speed-up-slow-tests
branch
from
September 9, 2026 16:26
10f3db7 to
ad182f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a bonus, point out in an explicit release note that we never did actually need clients to space out their credentials--by the time we released 10.0, that limitation was already obsolete.