Skip to content

Conversation

@MarianKijewski
Copy link
Contributor

@MarianKijewski MarianKijewski commented Nov 17, 2025


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

No documentation for events handler methods.

Solutions

Write documentation.

Notes

While writing the documentation I noticed some unnecessary or unimplemented details on the SDK side.
I left them here as "TODO: ". I will open PRs on the SDK repo or open Jira tickets to address those issues.

Here's how it looks on the demo page: Integration Docs | Handling Events


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

MarianKijewski and others added 30 commits November 14, 2025 18:31
There appears to be some issue with remoteData field, which makes Java interoperability not function.
note: not implemented in code
* Rename onMessage -> onTextMessageReceived

* Rename onConversationJoin -> onAppAddedToConversation

* Rename onConversationDelete -> onConversationDeleted

* Rename onAsset -> onAssetMessageReceived

* Rename onComposite -> onCompositeMessageReceived

* Rename onComposite -> onCompositeMessageReceived
Rename onButtonAction -> onButtonClicked
Rename onButtonActionConfirmation -> onButtonClickConfirmed
Rename onKnock -> onPingReceived
Rename onLocation -> onLocationMessageReceived
Rename onDeletedMessage -> onMessageDeleted
Rename onReceiptConfirmation -> onMessageDelivered
Rename onTextEdited -> onTextMessageEdited
Rename onCompositeEdited -> onCompositeMessageEdited
Rename onReaction -> onMessageReactionReceived
Rename onInCallEmoji -> onInCallReactionReceived
Rename onInCallHandRaise -> onInCallHandRaiseReceived
Rename onMemberJoin -> onUserJoinedConversation
Rename onMemberLeave -> onUserLeftConversation
@MarianKijewski MarianKijewski requested a review from a team as a code owner November 17, 2025 08:44
Copy link
Member

@alexandreferris alexandreferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🔥

members: List<QualifiedId>
) {
val users = members.map { manager.getUserSuspending(it) }
val welcomeText = buildString {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
val welcomeText = buildString {
val goodbyeText = buildString {

}
val message = WireMessage.Text.create(
conversationId = conversationId,
text = welcomeText
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
text = welcomeText
text = goodbyeText

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants