-
Notifications
You must be signed in to change notification settings - Fork 0
Docs/wpb-21095 add event handler methods reference #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MarianKijewski
wants to merge
32
commits into
main
Choose a base branch
from
docs/WPB-21095_event_handler_methods_reference
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Docs/wpb-21095 add event handler methods reference #5
MarianKijewski
wants to merge
32
commits into
main
from
docs/WPB-21095_event_handler_methods_reference
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There appears to be some issue with remoteData field, which makes Java interoperability not function.
note: not implemented in code
* Rename onMessage -> onTextMessageReceived * Rename onConversationJoin -> onAppAddedToConversation * Rename onConversationDelete -> onConversationDeleted * Rename onAsset -> onAssetMessageReceived * Rename onComposite -> onCompositeMessageReceived * Rename onComposite -> onCompositeMessageReceived Rename onButtonAction -> onButtonClicked Rename onButtonActionConfirmation -> onButtonClickConfirmed Rename onKnock -> onPingReceived Rename onLocation -> onLocationMessageReceived Rename onDeletedMessage -> onMessageDeleted Rename onReceiptConfirmation -> onMessageDelivered Rename onTextEdited -> onTextMessageEdited Rename onCompositeEdited -> onCompositeMessageEdited Rename onReaction -> onMessageReactionReceived Rename onInCallEmoji -> onInCallReactionReceived Rename onInCallHandRaise -> onInCallHandRaiseReceived Rename onMemberJoin -> onUserJoinedConversation Rename onMemberLeave -> onUserLeftConversation
alexandreferris
approved these changes
Nov 18, 2025
Member
alexandreferris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🔥
| members: List<QualifiedId> | ||
| ) { | ||
| val users = members.map { manager.getUserSuspending(it) } | ||
| val welcomeText = buildString { |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| val welcomeText = buildString { | |
| val goodbyeText = buildString { |
| } | ||
| val message = WireMessage.Text.create( | ||
| conversationId = conversationId, | ||
| text = welcomeText |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| text = welcomeText | |
| text = goodbyeText |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
No documentation for events handler methods.
Solutions
Write documentation.
Notes
While writing the documentation I noticed some unnecessary or unimplemented details on the SDK side.
I left them here as "TODO: ". I will open PRs on the SDK repo or open Jira tickets to address those issues.
Here's how it looks on the demo page: Integration Docs | Handling Events
PR Post Submission Checklist for internal contributors (Optional)
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.