-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enter to sent message part-1 [WPB-15369] #3839
Conversation
# Conflicts: # app/src/main/kotlin/com/wire/android/ui/home/messagecomposer/MessageComposerInput.kt
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3839 +/- ##
===========================================
+ Coverage 45.19% 45.21% +0.02%
===========================================
Files 491 491
Lines 16989 16999 +10
Branches 2845 2845
===========================================
+ Hits 7678 7686 +8
- Misses 8527 8529 +2
Partials 784 784
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3839.apk is available for download |
Built wire-android-dev-debug-pr-3839.apk is available for download |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
basically looks cool, just small suggestion :)
@@ -232,4 +233,9 @@ class GlobalDataStore @Inject constructor(@ApplicationContext private val contex | |||
fun selectedThemeOptionFlow(): Flow<ThemeOption> = | |||
getStringPreference(APP_THEME_OPTION, ThemeOption.SYSTEM.toString()) | |||
.map { ThemeOption.valueOf(it) } | |||
|
|||
fun enterToSendFlow(): Flow<Boolean> = getBooleanPreference(ENTER_TO_SENT, false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as far as it's used only as enterToSendFlow().first()
maybe make sens to change it to suspend fun isEnterToSend(): Boolean
|
Built wire-android-staging-compat-pr-3839.apk is available for download |
Built wire-android-dev-debug-pr-3839.apk is available for download |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.