Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate to Team analytics update WPB-16050 #3877

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Feb 14, 2025

TaskWPB-16050 [Android] Modification of personal-to-teams events

What's new in this PR?

Updates in migrate from Personal to Team account.
remove events:

  • ui.clicked-profile
  • ui.clicked-personal-migration-cta
  • user.personal-team-creation-flow-started
  • user.personal-team-creation-flow-stopped
  • user.personal-team-creation-flow-cancelled
  • user.personal-team-creation-flow-completed

add events:

  • user.personal-to-team-flow-team-plan-1 (with parameter migration_dot_active)
  • user.personal-to-team-flow-team-name-2
  • user.personal-to-team-flow-confirm-3
  • user.personal-to-team-flow-completed-4

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.

Project coverage is 45.32%. Comparing base (dc3887f) to head (d3e35f0).

Files with missing lines Patch % Lines
...serprofile/teammigration/TeamMigrationViewModel.kt 56.25% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3877      +/-   ##
===========================================
- Coverage    45.39%   45.32%   -0.07%     
===========================================
  Files          491      491              
  Lines        17036    17026      -10     
  Branches      2850     2852       +2     
===========================================
- Hits          7733     7717      -16     
- Misses        8514     8518       +4     
- Partials       789      791       +2     
Files with missing lines Coverage Δ
...n/kotlin/com/wire/android/ui/home/HomeViewModel.kt 62.74% <100.00%> (-2.71%) ⬇️
...id/ui/userprofile/self/SelfUserProfileViewModel.kt 54.41% <ø> (-0.99%) ⬇️
...ui/userprofile/teammigration/TeamMigrationState.kt 100.00% <100.00%> (ø)
...serprofile/teammigration/TeamMigrationViewModel.kt 75.51% <56.25%> (-13.17%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc3887f...d3e35f0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants