Skip to content

Conversation

@saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Oct 10, 2025

TaskWPB-20264 [Android] Lists of Meetings with groups (Ongoing, Today, and Tomorrow)


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • Added MeetingListItem sealed interface to have single parent for items and headers
  • Renamed UIMeeting to MeetingItem and created MeetingHeader model for different headers
  • Created composables for each header type and "Show All" footer
  • Created MeetingList composable for showing a list of meetings for each tab (next, past)
  • Implemented MeetingListViewModel which provides PagingData and contains logic of grouping meetings by dates and hours by adding proper headers to the list and expanding it when “Show All” is pressed
  • Fixed logic of calculating duration for ongoing meeting
  • Extracted CurrentTimeScope into a dedicated file and created “remember” and “preview” functions
  • Created a provider for mock items which chooses proper mocks depending on the list type (next, past) and whether it should show all items or only recent ones
  • Changed flowOf to MutableStateFlow because otherwise previews are empty when PagingData is used
Screen_recording_20251009_180447.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.77%. Comparing base (379c09f) to head (6577009).

Files with missing lines Patch % Lines
...d/ui/home/conversations/media/FileAssetsContent.kt 0.00% 1 Missing ⚠️
.../ui/home/conversations/media/ImageAssetsContent.kt 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4335   +/-   ##
========================================
  Coverage    47.77%   47.77%           
========================================
  Files          525      525           
  Lines        17941    17941           
  Branches      2954     2954           
========================================
  Hits          8571     8571           
  Misses        8486     8486           
  Partials       884      884           
Files with missing lines Coverage Δ
...d/ui/home/conversations/media/FileAssetsContent.kt 0.00% <0.00%> (ø)
.../ui/home/conversations/media/ImageAssetsContent.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 379c09f...6577009. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

@saleniuk saleniuk requested a review from sbakhtiarov October 14, 2025 14:53
@saleniuk saleniuk added this pull request to the merge queue Oct 17, 2025
Merged via the queue into develop with commit 295fcf9 Oct 17, 2025
15 of 16 checks passed
@saleniuk saleniuk deleted the feat/meetings/meeting-lists-grouped-by-date-and-hour branch October 17, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants