-
Notifications
You must be signed in to change notification settings - Fork 43
Mo/refactor/remove epoch from local db #4342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #4342 +/- ##
===========================================
- Coverage 47.77% 47.74% -0.03%
===========================================
Files 525 525
Lines 17941 17950 +9
Branches 2954 2957 +3
===========================================
Hits 8571 8571
- Misses 8486 8494 +8
- Partials 884 885 +1
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
app stores the epoch in the database and it is guaranteed to be not the correct one, since only CC have the current epoch stored (for conversations where self is part of) and the server also have the correct for conversations that self is not a member of
Causes (Optional)
needing epoch during slow sync
Solutions
the app already does call the server for the group context, so we can parse that to get the correct epoch for the conversation.
this does effect stale conversation and joining or establishing MLS conversations so please focus on this part the most
NOTE: there is still one use case missing to get the current epoch from CC this is needed to show it in the debug UI
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.