Skip to content

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

app stores the epoch in the database and it is guaranteed to be not the correct one, since only CC have the current epoch stored (for conversations where self is part of) and the server also have the correct for conversations that self is not a member of

Causes (Optional)

needing epoch during slow sync

Solutions

the app already does call the server for the group context, so we can parse that to get the correct epoch for the conversation.

this does effect stale conversation and joining or establishing MLS conversations so please focus on this part the most

NOTE: there is still one use case missing to get the current epoch from CC this is needed to show it in the debug UI

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

codecov bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.74%. Comparing base (bbb9919) to head (e9ad4bd).

Files with missing lines Patch % Lines
...i/debug/conversation/DebugConversationViewModel.kt 0.00% 8 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4342      +/-   ##
===========================================
- Coverage    47.77%   47.74%   -0.03%     
===========================================
  Files          525      525              
  Lines        17941    17950       +9     
  Branches      2954     2957       +3     
===========================================
  Hits          8571     8571              
- Misses        8486     8494       +8     
- Partials       884      885       +1     
Files with missing lines Coverage Δ
...ations/details/options/GroupConversationOptions.kt 0.00% <ø> (ø)
...i/debug/conversation/DebugConversationViewModel.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbb9919...e9ad4bd. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant