Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate symbols - WPB-15347 #2378

Draft
wants to merge 23 commits into
base: release/cycle-3.117
Choose a base branch
from

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Jan 13, 2025

BugWPB-15347 [iOS] Issues with linking dependencies

Issue

This PR intents to fix the following run-time warning:

objc[7471]: Class _TtC13WireAnalyticsP33_8BD82122A1FD2C8934CBAC6E445B31AB12BundleFinder is implemented in both wire-ios-mono/Build/Products/Debug-iphonesimulator/PackageFrameworks/WireAnalytics_72DE60DCE7DDA74C_PackageProduct.framework/WireAnalytics_72DE60DCE7DDA74C_PackageProduct (0x105be4278) and ~/Library/Developer/CoreSimulator/Devices/F5534429-867A-4E85-9069-65D58ACAF910/data/Containers/Bundle/Application/FE7E4197-1F98-402F-A1EB-795D7D48982F/Wire.app/Wire.debug.dylib (0x10991fdd8). One of the two will be used. Which one is undefined.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@caldrian caldrian changed the title fix: duplicate symbols fix: duplicate symbols - WPB-15347 Jan 13, 2025
@echoes-hq echoes-hq bot added the echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... label Jan 13, 2025
@caldrian caldrian force-pushed the fix/duplicate-symbols branch from 2fb29a2 to 0c1547d Compare January 13, 2025 09:17
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still relevant? is it working?

@caldrian
Copy link
Contributor Author

still relevant? is it working?

relevant: yes
working: not yet
@netbe

@caldrian caldrian force-pushed the fix/duplicate-symbols branch from da77492 to 9c2178e Compare January 22, 2025 09:46
@caldrian caldrian changed the base branch from release/cycle-3.115 to release/cycle-3.116 January 22, 2025 09:46
@caldrian caldrian changed the base branch from release/cycle-3.116 to chore/remove-wiredomainapi-cherry-pick-WPB-10347 January 22, 2025 09:58
Base automatically changed from chore/remove-wiredomainapi-cherry-pick-WPB-10347 to release/cycle-3.116 January 22, 2025 13:46
@caldrian caldrian changed the base branch from release/cycle-3.116 to release/cycle-3.117 January 30, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants