-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: duplicate symbols - WPB-15347 #2378
Draft
caldrian
wants to merge
23
commits into
release/cycle-3.117
Choose a base branch
from
fix/duplicate-symbols
base: release/cycle-3.117
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+7,600
−931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2fb29a2
to
0c1547d
Compare
Co-authored-by: Christoph Aldrian <[email protected]>
netbe
reviewed
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still relevant? is it working?
relevant: yes |
da77492
to
9c2178e
Compare
Base automatically changed from
chore/remove-wiredomainapi-cherry-pick-WPB-10347
to
release/cycle-3.116
January 22, 2025 13:46
Co-authored-by: Sam Wyndham <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: zenkins <[email protected]>
…o fix/duplicate-symbols # Conflicts: # WireUI/Package.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
echoes: technical-roadmap/throughput
More specific category, to highlight task aiming at improving the development velocity and effici...
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR intents to fix the following run-time warning:
objc[7471]: Class _TtC13WireAnalyticsP33_8BD82122A1FD2C8934CBAC6E445B31AB12BundleFinder is implemented in both wire-ios-mono/Build/Products/Debug-iphonesimulator/PackageFrameworks/WireAnalytics_72DE60DCE7DDA74C_PackageProduct.framework/WireAnalytics_72DE60DCE7DDA74C_PackageProduct (0x105be4278) and ~/Library/Developer/CoreSimulator/Devices/F5534429-867A-4E85-9069-65D58ACAF910/data/Containers/Bundle/Application/FE7E4197-1F98-402F-A1EB-795D7D48982F/Wire.app/Wire.debug.dylib (0x10991fdd8). One of the two will be used. Which one is undefined.
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: