Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add screen for No history - WPB-15227 #2509

Merged
merged 10 commits into from
Feb 12, 2025
Merged

feat: Add screen for No history - WPB-15227 #2509

merged 10 commits into from
Feb 12, 2025

Conversation

KaterinaWire
Copy link
Contributor

@KaterinaWire KaterinaWire commented Feb 10, 2025 •
edited
Loading

Issue

First time login

If a user has no history to be loaded on this device, the following screen is shown:

Screenshot 2025-02-10 at 17 23 14

Testing

Describe how to test.

Optional: attachments like images, videos, etc.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 10, 2025 •
edited
Loading

Test Results

24 tests   24 ✅  5s ⏱️
 3 suites   0 💤
 1 files     0 ❌

Results for commit ea7ebeb.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Feb 10, 2025 •
edited
Loading

Datadog Report

Branch report: feat/first-time-screen-WPB-15227
Commit report: 2d9fa83
Test service: wire-ios-mono

✅ 0 Failed, 19 Passed, 0 Skipped, 5.04s Total Time

samwyndham
samwyndham approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

WireAuthentication/Sources/WireAuthenticationUI/Views/Login/NoHistory/NoHistoryView.swift Show resolved Hide resolved
@KaterinaWire KaterinaWire added this pull request to the merge queue Feb 12, 2025
Merged via the queue into develop with commit 6ca59b2 Feb 12, 2025
10 checks passed
@KaterinaWire KaterinaWire deleted the feat/first-time-screen-WPB-15227 branch February 12, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samwyndham samwyndham samwyndham approved these changes

@caldrian caldrian caldrian approved these changes

@jullianm jullianm Awaiting requested review from jullianm

Assignees

@KaterinaWire KaterinaWire

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KaterinaWire @samwyndham @caldrian