Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: various UI issues in Backup/Restore - WPB-16078 #2533

Open
wants to merge 406 commits into
base: release/cycle-3.118
Choose a base branch
from

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Feb 13, 2025

BugWPB-16078 [iOS, iPad] Minor left-over bugs in Backup/Restore

Issue

This PR attempts to fix a few left-over issues, like

  • the height of sheets
  • little issues like the password text field losing focus when tapping the toggle button
  • accent color propagation to the new sheets
  • accessibility label for toggle password visibility icon

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@caldrian caldrian marked this pull request as ready for review February 13, 2025 14:54
Copy link
Contributor

github-actions bot commented Feb 13, 2025

Test Results

    4 files     14 suites   4m 40s ⏱️
3 263 tests 3 234 ✅ 29 💤 0 ❌
3 273 runs  3 244 ✅ 29 💤 0 ❌

Results for commit bd75a1d.

♻️ This comment has been updated with latest results.

@caldrian caldrian removed the WIP label Feb 14, 2025
@caldrian caldrian force-pushed the fix/various-issues-WPB-16078 branch from 56b8580 to 1ea0e1a Compare February 14, 2025 16:43
@wireapp wireapp deleted a comment from datadog-wireapp bot Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants