Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add WireSettingsUI strings to crowdin.yml - WPB-16078 #2542

Merged
merged 1 commit into from
Feb 14, 2025
Merged

fix: add WireSettingsUI strings to crowdin.yml - WPB-16078 #2542

merged 1 commit into from
Feb 14, 2025

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Feb 14, 2025 •
edited by github-actions bot
Loading

BugWPB-16078 [iOS, iPad] Minor left-over bugs in Backup/Restore

Issue

New string files currently aren't processed by crowdin, because PR #2523 hasn't updated the config file.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@caldrian caldrian requested a review from jullianm February 14, 2025 13:52
@caldrian caldrian enabled auto-merge February 14, 2025 13:53
@github-actions GitHub Actions
Copy link
Contributor

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 3df90e2.

netbe
netbe approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚒️

@caldrian caldrian added this pull request to the merge queue Feb 14, 2025
Merged via the queue into develop with commit 945c089 Feb 14, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netbe netbe netbe approved these changes

@KaterinaWire KaterinaWire KaterinaWire approved these changes

@jullianm jullianm Awaiting requested review from jullianm

Assignees

@caldrian caldrian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caldrian @netbe @KaterinaWire