Skip to content

fix: reduce memory pressure #4857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
netbe wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

fix: reduce memory pressure #4857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions wire-ios/Wire-iOS/Sources/Helpers/ImageCache.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,28 @@ final class ImageCache<T: AnyObject> {
var cache: NSCache<NSString, T> = NSCache()
var processingQueue = DispatchQueue(label: "ImageCacheQueue", qos: .background, attributes: [.concurrent])
var dispatchGroup: DispatchGroup = .init()

private var backgroundObserver: (any NSObjectProtocol)?

init() {
// Drop decoded images when the app is backgrounded. NSCache only evicts reliably
// while in the foreground, so without this the cached images stay resident and inflate
// the suspended app's memory footprint, making it a prime target for jetsam
// ("System Pressure" background terminations).
backgroundObserver = NotificationCenter.default.addObserver(
forName: UIApplication.didEnterBackgroundNotification,
object: nil,
queue: .main
) { [weak self] _ in
self?.cache.removeAllObjects()
}
}

deinit {
if let backgroundObserver {
NotificationCenter.default.removeObserver(backgroundObserver)
}
}
}

extension UIImage {
Expand Down
Loading