feat: add hardware keyboard navigation from input fields - WPB-14697 - #5085
Open
acv-w wants to merge 1 commit into
Open
feat: add hardware keyboard navigation from input fields - WPB-14697#5085acv-w wants to merge 1 commit into
acv-w wants to merge 1 commit into
Conversation
acv-w
requested review from
a team,
David-Henner and
caldrian
and removed request for
a team
July 30, 2026 16:41
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves hardware keyboard navigation in the app’s conversation UI by ensuring Tab can move focus out of text input fields (message composer and conversation search) and by making the conversation list focusable via the focus engine.
Changes:
- Enabled focus on the conversation list
UICollectionViewto allow keyboard focus on list content. - Intercepted Tab in the conversation search bar to resign first responder and trigger a focus update.
- Added
preferredFocusEnvironmentsoverrides for both the conversation list and the input bar to steer focus out of active text fields toward appropriate UI controls.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| wire-ios/Wire-iOS/Sources/UserInterface/ConversationList/ListContent/ConversationListContentController/ConversationListContentController.swift | Enables focus on the conversation list collection view for keyboard navigation. |
| wire-ios/Wire-iOS/Sources/UserInterface/ConversationList/Container/ConversationListViewController+UISearchBarDelegate.swift | Handles Tab key in the search bar to move focus out of the search field. |
| wire-ios/Wire-iOS/Sources/UserInterface/ConversationList/Container/ConversationListViewController.swift | Adds focus-environment preference to direct focus to the conversation list when leaving search. |
| wire-ios/Wire-iOS/Sources/UserInterface/Conversation/InputBar/ConversationInputBarViewController+UITextViewDelegate.swift | Updates Tab handling in the composer to trigger focus updates before leaving the text view. |
| wire-ios/Wire-iOS/Sources/UserInterface/Conversation/InputBar/ConversationInputBarViewController/ConversationInputBarViewController.swift | Adds focus-environment preference to route focus to send/auxiliary buttons when leaving the composer. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+22
to
+34
| func searchBar( | ||
| _ searchBar: UISearchBar, | ||
| shouldChangeTextIn range: NSRange, | ||
| replacementText text: String | ||
| ) -> Bool { | ||
| guard text == "\t" else { return true } | ||
|
|
||
| let focusEnvironment = navigationController ?? self | ||
| focusEnvironment.setNeedsFocusUpdate() | ||
| focusEnvironment.updateFocusIfNeeded() | ||
| searchBar.searchTextField.resignFirstResponder() | ||
| return false | ||
| } |
Comment on lines
+312
to
+316
| override var preferredFocusEnvironments: [any UIFocusEnvironment] { | ||
| guard navigationItem.searchController?.searchBar.searchTextField.isFirstResponder == true else { | ||
| return super.preferredFocusEnvironments | ||
| } | ||
|
|
Comment on lines
86
to
90
| if text == "\t" { | ||
| setNeedsFocusUpdate() | ||
| updateFocusIfNeeded() | ||
| textView.resignFirstResponder() | ||
| UIAccessibility.post( |
Comment on lines
+195
to
+199
| override var preferredFocusEnvironments: [any UIFocusEnvironment] { | ||
| guard isViewLoaded, inputBar.textView.isFirstResponder else { | ||
| return super.preferredFocusEnvironments | ||
| } | ||
|
|
Comment on lines
151
to
155
|
|
||
| collectionView.alwaysBounceVertical = true | ||
| collectionView.allowsFocus = true | ||
| collectionView.allowsSelection = true | ||
| collectionView.allowsMultipleSelection = false |
Contributor
Test Results1 941 tests 1 914 ✅ 2m 56s ⏱️ Results for commit cdea14f. Summary: workflow run #30562635224 |
Contributor
|
This PR is stale because it has been open 30 days with no activity. Please update it or close it in case is not relevant anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Moves focus out of the message composer and conversation search when Tab is pressed, while preserving VoiceOver behavior. Conversation list cells are now keyboard-focusable.
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: