Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(WPB-15487): fix coturn port range in all the documentation #767

Merged
merged 5 commits into from
Mar 25, 2025

Conversation

mohitrajain
Copy link
Contributor

@mohitrajain mohitrajain commented Mar 14, 2025

Change type

  • Fix
  • Feature
  • Documentation
  • Security / Upgrade

Basic information

  • THIS CHANGE REQUIRES A DEPLOYMENT PACKAGE RELEASE
  • THIS CHANGE REQUIRES A WIRE-DOCS RELEASE

Testing

  • I ran/applied the changes myself, in a test environment.
  • The CI job attached to this repo will test it for me.

Tracking

  • I mentioned this PR in Jira, OR I mentioned the Jira ticket in this PR.
  • I mentioned this PR in one of the issues attached to one of our repositories.

Knowledge Transfer

  • An Asciinema session is attached to the Jira ticket.

Motivation

Objective

Reason

The port range is still pointing to restund port range and we should consider the coturn operating ports.

https://github.com/wireapp/coturn/blob/wireapp/4.6.2-helm-chart/src/apps/relay/turn_ports.h#L44

#define LOW_DEFAULT_PORTS_BOUNDARY (49152)
#define HIGH_DEFAULT_PORTS_BOUNDARY (65535)

https://www.rfc-editor.org/rfc/rfc5766 Page 26

   In all cases, the server SHOULD only allocate ports from the range
   49152 - 65535 (the Dynamic and/or Private Port range [Port-Numbers]),
   unless the TURN server application knows, through some means not
   specified here, that other applications running on the same host as
   the TURN server application will not be impacted by allocating ports
   outside this range.

We should also highlight the outbound incase of strict outbound rules.
https://docs.wire.com/understand/notes/port-ranges.html

Use case

@mohitrajain mohitrajain requested review from julialongtin and a team as code owners March 14, 2025 16:08
@julialongtin julialongtin merged commit ac0ff92 into master Mar 25, 2025
3 of 4 checks passed
@julialongtin julialongtin deleted the fix-coturn-port-range branch March 25, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants