WPB-15594 feat(bundle): add helm dependency chart#769
Closed
mohitrajain wants to merge 1 commit intomasterfrom
Closed
WPB-15594 feat(bundle): add helm dependency chart#769mohitrajain wants to merge 1 commit intomasterfrom
mohitrajain wants to merge 1 commit intomasterfrom
Conversation
…g used by helm charts
|
| # Linting | ||
| shellcheck | ||
|
|
||
| jq |
Contributor
Author
There was a problem hiding this comment.
ack, will consider it in the PR for refractor
| | yq -r '..|.image? | select(.)' | optionally_complain | sort -u | ||
| | yq -r '..|.image? | select(.)' | optionally_complain | sort -u > /tmp/images | ||
|
|
||
| echo "${chart}" >> "${chart_images}" |
Member
There was a problem hiding this comment.
this looks pretty hacky to me.
Contributor
Author
There was a problem hiding this comment.
this is just a temp file where i am redirecting the output for each chart. I can try storing it in a var but since there has been many redirections happening in this command, i redirected the output to one temp file. How do you suggest to handle this output?
mohitrajain
changed the title
Contributor
Author
|
will be closing this PR as its changes have been reflected in PR #771 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…g used by helm charts
Change type
Basic information
Testing
Tracking
Knowledge Transfer
Motivation
Objective
Reason
Use case