runfix: achieve WYSIWYG with lists and blockquotes markdown rendering [WPB-16228] #18850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V-Gira
commented
Mar 10, 2025
| @@ -129,6 +129,7 @@ const registerBlockquoteBackspaceCommand = (editor: LexicalEditor) => { | |||
| editor.update(() => { | |||
| lastChild.remove(); | |||
| editor.dispatchCommand(INSERT_PARAGRAPH_COMMAND, undefined); | |||
| editor.dispatchCommand(INSERT_PARAGRAPH_COMMAND, undefined); | |||
There was a problem hiding this comment.
adding an extra new line on backspace actually escape the blockquotes, and the added line is consistent with the message list md rendering
V-Gira
commented
Mar 10, 2025
Comment on lines
255
to
261
| // keep the list indentation for the next paragraph after the list | ||
| & + .editor-paragraph, | ||
| // and for every paragraph with text with a parent with text | ||
| // the ltr class is present for a paragraph with left-to-right text | ||
| & ~ .ltr + .ltr { | ||
| margin-left: 24px; | ||
| } |
There was a problem hiding this comment.
css spaghetti here.
lexical does not keep the next paragraph after a list in the ul, but markdownit does (it's standard md).
the css is for keeping the list indentation for a single paragraph after a list, and every paragraph after that that contain text (the ltr class is added by lexical to paragraphs with left-to-right text)
V-Gira
changed the title
waseemansar
approved these changes
Mar 10, 2025
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's a couple of discrepancies between markdown rendering in the input bar and the message list:
Screenshots/Screencast (for UI changes)
before
after
Checklist