Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve visibility of connection requests [WPB-14764] #18854

Merged
merged 3 commits into from
Mar 12, 2025

Conversation

V-Gira
Copy link
Contributor

@V-Gira V-Gira commented Mar 12, 2025

BugWPB-14764 [Web] Contact request is shown at the bottom of conversations list

Description

  • only show pending connection requests in All and 1:1 tabs
  • do not show the empty conversations status if there are pending connection requests

this only fixes the very visible bug, it also should make it a bit easier to implement the redesign coming later https://www.figma.com/design/jnygr7PEOk1yHgjBF18udc/Desktop

Screenshots/Screencast (for UI changes)

Before

image

After

image

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@V-Gira V-Gira merged commit 058b7ea into dev Mar 12, 2025
14 of 15 checks passed
@V-Gira V-Gira deleted the v/connection-request-bottom branch March 12, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants