feat: add channel avatars [WPB-15756] #18855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafsulich
approved these changes
Mar 13, 2025
| @@ -169,7 +172,17 @@ export const ConversationListCell = ({ | |||
| 'conversation-list-cell-left-opaque': isSelfUserRemoved || users.length === 0, | |||
| })} | |||
| > | |||
| {isGroup && <GroupAvatar conversationID={conversation.id} className="conversation-list-cell-avatar-arrow" />} | |||
| {/* show channel avatar for testing purpose */} | |||
There was a problem hiding this comment.
should this comment still be there?
There was a problem hiding this comment.
As I am merging to feature branch, this check is there only for testing.
Comment on lines
+176
to
+177
| {isGroup && | ||
| (conversationName && conversationName?.toLowerCase().includes('channel') ? ( |
There was a problem hiding this comment.
minor suggestion: move this to a variable, e.g. shouldShowChannelAvatar
There was a problem hiding this comment.
This will be removed anyway before merging to dev.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added channel avatars
Screenshots/Screencast (for UI changes)
Checklist