-
Notifications
You must be signed in to change notification settings - Fork 297
chore: Use beta version of web-packages on dev [WPB-21306] #19811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Bumps [rimraf](https://github.com/isaacs/rimraf) from 6.1.0 to 6.1.2. - [Changelog](https://github.com/isaacs/rimraf/blob/main/CHANGELOG.md) - [Commits](isaacs/rimraf@v6.1.0...v6.1.2) --- updated-dependencies: - dependency-name: rimraf dependency-version: 6.1.2 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…t tests with it (#19804) This is an attempt to resolve the race conditions happening when two users connect in a 1:1 for the first time starting the conversation as proteus but it's migrated to MLS automatically. This leads to a message sent during the migration being lost. Team members don't need to go through this step as they are aware of the spoken protocol of other members after login.
* test(TC-8038): add test for not replying to a ping * test(TC-8039): add test for not replying to timed messages * test(TC-2994): add test for quote in reply to vanish if source message is removed * test(TC-2996): add test for searching message * test(TC-2997): test for quote in reply to be truncated * test(TC-3002): reply to a picture * test(TC-3003): reply to an audio message * test(TC-3004): reply to video * test(TC-3005): reply to link * test(TC3006): reply to file * test(TC-3007): reply to reply * test(TC-3008): reply to link with text * test(TC-3011): Reply with timed message * test(TC-3013): test clicking the reply * test(TC-3014): test replying in a conversation I'm no longer part of * test(TC-3016): click on mention in reply opens user profile * fix: remove visibility check from sendMessage * test(TC-3009): add test case for replying to a location + util for sending location via testservice * refactor: replace createPagesForUser with new fixtures * refactor(test): use new fixtures for reply tests * refactor: remove no longer used PagePlugin withConversation
…/browse/WPB-20819) (#19714) * fix: make password toggle button accessible and localised(WPB-21228) * fix: translate type * fix: Login - New view is not announced * fix: make back button accessible WPB-21466 * fix: make external link 2fa accessible(WPB-21279) * fix: password toggle button text alternative(WPB-21228) * fix: make verify account header focusable using screenkey and login subheading style adjustments * fix: add toggle password show/hide label * fix: address review comments * chore: bump core packages * fix: pipeline issues * fix: PR comments * fix: pipeline issues
Bumps [@wireapp/core](https://github.com/wireapp/wire-web-packages) from 46.46.3 to 46.46.5. - [Commits](https://github.com/wireapp/wire-web-packages/compare/@wireapp/[email protected]...@wireapp/[email protected]) --- updated-dependencies: - dependency-name: "@wireapp/core" dependency-version: 46.46.5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.46.0 to 3.47.0. - [Release notes](https://github.com/zloirock/core-js/releases) - [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/zloirock/core-js/commits/v3.47.0/packages/core-js) --- updated-dependencies: - dependency-name: core-js dependency-version: 3.47.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [emoji-picker-react](https://github.com/ealush/emoji-picker-react) from 4.15.1 to 4.15.2. - [Release notes](https://github.com/ealush/emoji-picker-react/releases) - [Commits](https://github.com/ealush/emoji-picker-react/commits) --- updated-dependencies: - dependency-name: emoji-picker-react dependency-version: 4.15.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [html-webpack-plugin](https://github.com/jantimon/html-webpack-plugin) from 5.6.4 to 5.6.5. - [Release notes](https://github.com/jantimon/html-webpack-plugin/releases) - [Changelog](https://github.com/jantimon/html-webpack-plugin/blob/main/CHANGELOG.md) - [Commits](jantimon/html-webpack-plugin@v5.6.4...v5.6.5) --- updated-dependencies: - dependency-name: html-webpack-plugin dependency-version: 5.6.5 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [oidc-client-ts](https://github.com/authts/oidc-client-ts) from 3.4.0 to 3.4.1. - [Release notes](https://github.com/authts/oidc-client-ts/releases) - [Commits](authts/oidc-client-ts@v3.4.0...v3.4.1) --- updated-dependencies: - dependency-name: oidc-client-ts dependency-version: 3.4.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [webpack](https://github.com/webpack/webpack) from 5.102.1 to 5.103.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.102.1...v5.103.0) --- updated-dependencies: - dependency-name: webpack dependency-version: 5.103.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
) Bumps [workbox-webpack-plugin](https://github.com/googlechrome/workbox) from 7.3.0 to 7.4.0. - [Release notes](https://github.com/googlechrome/workbox/releases) - [Commits](GoogleChrome/workbox@v7.3.0...v7.4.0) --- updated-dependencies: - dependency-name: workbox-webpack-plugin dependency-version: 7.4.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [stylelint](https://github.com/stylelint/stylelint) from 16.25.0 to 16.26.0. - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint@16.25.0...16.26.0) --- updated-dependencies: - dependency-name: stylelint dependency-version: 16.26.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…19792) Bumps [baseline-browser-mapping](https://github.com/web-platform-dx/baseline-browser-mapping) from 2.8.28 to 2.8.31. - [Release notes](https://github.com/web-platform-dx/baseline-browser-mapping/releases) - [Commits](web-platform-dx/baseline-browser-mapping@v2.8.28...v2.8.31) --- updated-dependencies: - dependency-name: baseline-browser-mapping dependency-version: 2.8.31 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* test(TC-657): add test for sending ephemeral text message in 1:1 * test(TC-658): add test for sending ephemeral text message in group * refactor: replace util sendTimedMessage with dedicated utils for enabling and disabling timed messages * test(TC-662): Verify timer is applied to all messages until turning it off in 1:1 * test(TC-664): Verify that message with previous timer are deleted on start-up when the timeout passed in 1:1 * refactor: overload createPage fixture to optionally accept a context to reuse * refactor: use team for tests using new fixture * test(TC-675): Verify the message is not deleted for users that didn't read the message * test(TC-3715): set global group conversation timer * refactor(reply-tests): remove unused createUser fixture * test(TC-3716): check current time is visible in details * fix(a11y): add disabled attribute to MessageTimerButton * test(TC-3718): check timed message button is disabled if timed messages are set globally * test(TC-3719): globally set timer is shown on button next to input field * test(TC-3720): system messages are shown for enabled / disabled timer messages * test(TC-3717): check ephemeral message appear in search results * test(TC-3731): add test for message to disappear from search results (currently broken) * refactor: group search tests * refactor: update search result tests to do assertions on receiver side * refactor: group tests with self deleting messages set globally for a group conversation * docs: add ticket number to comment for skipped test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates all @wireapp/ packages from stable to beta versions for testing on the dev environment as part of WPB-21306. The beta versions follow a consistent naming pattern with commit hash references (e.g., 5.4.10-beta.54.5ce5ca523), enabling testing of pre-release features before production deployment.
Key changes:
- Updated 11 direct
@wireapp/dependencies to beta versions with commit hash identifiers - Updated ESLint configuration introduces modern tooling (eslint-plugin-jest v29, eslint-plugin-react-hooks v5, etc.)
- New transitive dependencies added for improved module resolution and WASM/NAPI runtime support
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updated 11 @wireapp packages to beta versions in both dependencies and devDependencies sections |
| yarn.lock | Lockfile update reflecting package.json changes, plus transitive dependency additions from @wireapp/eslint-config update (unrs-resolver with platform bindings, @emnapi packages, and updated ESLint plugins) |
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
Failed Tests:❌ Account Management (tags: TC-8639, crit-flow-web)Location: specs/CriticalFlow/accountManagement-TC-8639.spec.ts:37 Errors: ❌ Team owner adds whole team to an all team chat (tags: TC-8631, crit-flow-web)Location: specs/CriticalFlow/addMembersToChat-TC-8631.spec.ts:43 Errors: ❌ Planning group call with sending various messages during call (tags: TC-8632, crit-flow-web)Location: specs/CriticalFlow/groupCalls-TC-8632.spec.ts:37 Errors: ❌ Group Video call (tags: TC-8637, crit-flow-web)Location: specs/CriticalFlow/groupVideoCall-TC-8637.spec.ts:39 Errors: ❌ New person joins team and setups up device (tags: TC-8635, crit-flow-web)Location: specs/CriticalFlow/joinTeam-TC-8635.spec.ts:38 Errors: Flaky Tests: |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| 'react-hooks/rules-of-hooks': 'off', | ||
| 'react-hooks/exhaustive-deps': 'off', |
Copilot
AI
Nov 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new @wireapp/[email protected] upgrades eslint-plugin-react-hooks from v4 to v5. Disabling these rules specifically for test files may be hiding issues that should be addressed. Consider:
- Investigate why tests are failing with the stricter react-hooks rules in v5
- Fix the test code to comply with the rules rather than disabling them
- If disabling is truly necessary, document why with a comment explaining the rationale
These rules help prevent common React bugs:
rules-of-hooksensures hooks are only called at the top levelexhaustive-depsprevents stale closures and missing dependencies
| 'react-hooks/rules-of-hooks': 'off', | |
| 'react-hooks/exhaustive-deps': 'off', | |
| // If you need to disable react-hooks rules for tests, document the rationale here. | |
| // 'react-hooks/rules-of-hooks': 'off', | |
| // 'react-hooks/exhaustive-deps': 'off', |
| "@wireapp/react-ui-kit": "9.69.7-beta.11.d0ceefa60", | ||
| "@wireapp/store-engine-dexie": "2.1.21-beta.54.5ce5ca523", | ||
| "@wireapp/telemetry": "0.3.7-beta.51.d0ceefa60", | ||
| "@wireapp/webapp-events": "0.28.6-beta.51.d0ceefa60", |
Copilot
AI
Nov 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The beta versions use three different commit hashes (5ce5ca523, d0ceefa60, a0e2528f5), which suggests these packages were built from different commits. This creates an inconsistent dependency state that could lead to:
- Unexpected integration issues between packages built at different times
- Difficulty reproducing and debugging issues
- Unclear which version of the codebase is actually deployed
Consider coordinating the beta releases to use a single commit hash across all @wireapp packages, or document why different commits are necessary for this migration.
| "@wireapp/react-ui-kit": "9.69.7-beta.11.d0ceefa60", | |
| "@wireapp/store-engine-dexie": "2.1.21-beta.54.5ce5ca523", | |
| "@wireapp/telemetry": "0.3.7-beta.51.d0ceefa60", | |
| "@wireapp/webapp-events": "0.28.6-beta.51.d0ceefa60", | |
| "@wireapp/react-ui-kit": "9.69.7-beta.11.5ce5ca523", | |
| "@wireapp/store-engine-dexie": "2.1.21-beta.54.5ce5ca523", | |
| "@wireapp/telemetry": "0.3.7-beta.51.5ce5ca523", | |
| "@wireapp/webapp-events": "0.28.6-beta.51.5ce5ca523", |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #19811 +/- ##
=======================================
Coverage 43.46% 43.46%
=======================================
Files 1296 1296
Lines 32570 32570
Branches 7232 7232
=======================================
Hits 14157 14157
Misses 16698 16698
Partials 1715 1715 🚀 New features to boost your workflow:
|



Pull Request
Summary
Migrated all of web-packages to use the beta version as part of WPB-21306
none
Security Checklist (required)
Standards Acknowledgement (required)