-
Notifications
You must be signed in to change notification settings - Fork 297
feat: replace button with div and assigned role=button to it [WPB-21194] #19846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace button with div and assigned role=button to it [WPB-21194] #19846
Conversation
e-maad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Just a concern, did we try our best to make button work with keyboard navigation?
It is actually against accessibility guidelines.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #19846 +/- ##
==========================================
+ Coverage 43.73% 43.75% +0.02%
==========================================
Files 1299 1300 +1
Lines 32744 32761 +17
Branches 7268 7271 +3
==========================================
+ Hits 14321 14335 +14
- Misses 16703 16704 +1
- Partials 1720 1722 +2 🚀 New features to boost your workflow:
|
…94] (#19846) * feat: add aria label and also title on the close screen share icon * feat: replace button with div and assigned role=button to it. Move inline css to styles.ts * feat: call controls were not working using keyboard.



Summary
Replace button with div and assigned role=button
Move inline css to styles.ts
Call Controls were working on mouse but not working on via keyboard. Now it is working
Security Checklist (required)
Standards Acknowledgement (required)
Screenshots or demo (if the user interface changed)
Notes for reviewers