Skip to content

Conversation

@zskhan
Copy link
Contributor

@zskhan zskhan commented Dec 5, 2025

TaskWPB-21194 [Web] Calling - Own profile picture in the call incorrectly marked as a button

Summary

Replace button with div and assigned role=button
Move inline css to styles.ts
Call Controls were working on mouse but not working on via keyboard. Now it is working

  • What did I change and why?
  • Risks and how to roll out / roll back (e.g. feature flags):

Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Standards Acknowledgement (required)


Screenshots or demo (if the user interface changed)

Notes for reviewers

  • Trade-offs:
  • Follow-ups (linked issues):
  • Linked PRs (e.g. web-packages):

Copy link
Contributor

@e-maad e-maad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Just a concern, did we try our best to make button work with keyboard navigation?
It is actually against accessibility guidelines.

Base automatically changed from feat/accessibility-close-screen-share-btn to dev December 8, 2025 10:26
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2025

@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 65.62500% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.75%. Comparing base (58033d7) to head (85f4dd1).
⚠️ Report is 9 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #19846      +/-   ##
==========================================
+ Coverage   43.73%   43.75%   +0.02%     
==========================================
  Files        1299     1300       +1     
  Lines       32744    32761      +17     
  Branches     7268     7271       +3     
==========================================
+ Hits        14321    14335      +14     
- Misses      16703    16704       +1     
- Partials     1720     1722       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zskhan zskhan merged commit c639bc9 into dev Dec 8, 2025
13 checks passed
@zskhan zskhan deleted the feat/accessibility-profile-picture-in-call-marked-as-btn branch December 8, 2025 10:36
aweiss-dev pushed a commit that referenced this pull request Dec 8, 2025
…94] (#19846)

* feat: add aria label and also title on the close screen share icon

* feat: replace button with div and assigned role=button to it. Move inline css to styles.ts

* feat: call controls were not working using keyboard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants