MappingSerializer (Newtonsoft or SystemText)-Json #1394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1394 +/- ##
==========================================
+ Coverage 34.85% 36.27% +1.42%
==========================================
Files 153 154 +1
Lines 37089 36891 -198
==========================================
+ Hits 12928 13384 +456
+ Misses 23725 23081 -644
+ Partials 436 426 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the mapping deserialization logic to support multiple JSON converters (Newtonsoft.Json or System.Text.Json) for MappingModel serialization. The changes introduce a new MappingSerializer class that abstracts the JSON conversion logic and allows users to configure which JSON converter to use via WireMockServerSettings.
Key Changes
- Introduced a new
MappingSerializerclass that supports both Newtonsoft.Json and System.Text.Json converters - Added a
MappingJsonSerializerproperty toWireMockServerSettingsto allow customization of the JSON converter - Refactored existing deserialization methods from static helper methods in
WireMockServer.Admin.csto use the newMappingSerializerinstance - Added comprehensive unit tests covering both JSON converters with various edge cases
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| test/WireMock.Net.Tests/Serialization/MappingSerializerTests.cs | New test file with comprehensive coverage for MappingSerializer using both Newtonsoft.Json and System.Text.Json converters |
| src/WireMock.Net.Shared/Settings/WireMockServerSettings.cs | Added new property to configure the JSON converter for mapping serialization |
| src/WireMock.Net.Minimal/WireMock.Net.Minimal.csproj | Updated package references to include JsonConverter packages for different target frameworks |
| src/WireMock.Net.Minimal/Server/WireMockServer.cs | Added MappingSerializer field and initialization with configured or default JSON converter |
| src/WireMock.Net.Minimal/Server/WireMockServer.ImportWireMockOrg.cs | Updated to use the new MappingSerializer instance instead of static methods |
| src/WireMock.Net.Minimal/Server/WireMockServer.Admin.cs | Refactored static deserialization methods to use MappingSerializer; moved method and removed old implementation |
| src/WireMock.Net.Minimal/Serialization/MappingSerializer.cs | New internal class that handles deserialization of JSON to arrays, supporting both Newtonsoft.Json and System.Text.Json |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.