-
Notifications
You must be signed in to change notification settings - Fork 0
File upload #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
File upload #3
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1543e2b
feat: pdf/csv/txt/md/jpeg/png/heic model-permission based upload
Ericzhou-ez c4b1e2a
fix: attatchment persistence upon model change
Ericzhou-ez 6d40823
improv: type-safety, file-sanitization&validation, error handling
Ericzhou-ez eb185ab
fix: UI in artifact
Ericzhou-ez 795afa9
perf: rm blob after deleting chat
Ericzhou-ez 7cbd278
cleanup: cleaned up stale guest logic
Ericzhou-ez c0af931
Polarity Optimize PR request
Ericzhou-ez c67fa7a
Polarity Optimize PR request
Ericzhou-ez 8f9b443
fix: gemini-suggested fixes
Ericzhou-ez bdb3392
fix: rerender to display streaming
Ericzhou-ez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The max size for text files (
0.5 * 1024 * 1024) is hardcoded here. It would be better to define this as a named constant, for exampleMAX_TEXT_FILE_SIZE_BYTES, at the top of the file or in a shared constants file. This improves maintainability and makes the code easier to understand.