-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eagerness
option description and example for prefetch()
#11250
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting the docs for this great new feature, @Marocco2 ! I'm sure people will really appreciate having this!
I just made some editing suggestions to make this sound more like the rest of our docs and follow some of our styles. You are the expert in this topic, so please correct anything that's wrong, and make any suggestions back if something needs fixing!
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Thank you for taking your time making the changes! I found all of them reasonable, so I've merged them 👍 |
Thank you! From now on, these docs should not change too much, but probably just typos etc. In that case, I will commit small fixes directly so that you do not have to be bothered. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, good work!
Co-authored-by: Yan <[email protected]>
Would love a final approval from @Marocco2 here, as I added some stuff, so make sure this all still seems correct! @ArmandPhilippot , I added the API reference at the top so couldn't hurt for you to confirm. 😄 Then, I think this is ready to merge into the 5.6.0 PR branch for this week's release! 🥳 |
I've checked. All good 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarah11918 The API reference seems fine to me! However, I don't understand why, I can't see it in the preview (there is only Since
):
Edit: I copied the changes locally to test, and this works fine with the dev server. So I guess it's just a bug in the preview?
@ArmandPhilippot It's because previews aren't generated for PRs not to the main branch! (I forget sometimes myself.) We can double double check once it's merged into the 5.6.0 PR, because that is made to the main branch. I switched target branches earlier than usual, because we're ahead of the game, but I forgot (myself) that we lose previews that way. |
Description (required)
As per request, I've added a new section for Prefetch docs page describing what the new option does and a use case that it would be useful
For Astro version:
5.6
. See astro PR #13405