-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
i18n(de): translate tutorial section 5 #12501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: de/tutorial
Are you sure you want to change the base?
i18n(de): translate tutorial section 5 #12501
Conversation
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
In this PR the German tutorial is bugged. I guess this is because the sections before do not exist here (haven't looking into the processing of the tutorial yet. But I assume this is fixed when all sections are combined in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve left some review comments on this PR.
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Awesome finds @randomguy-2650 🙌 Could you please take a look at https://github.com/withastro/docs/pull/12500/files#r2404391432? |
That symbol I used is just the Unicode character for the non-breaking space instead of the HTML |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve left extra review comments I’ve forgot before.
The reason I know all of these random orthographic rules is due to this absurdly strict style guide I’ve created.
English: https://github.com/placer-toolkit/placer-style-guide/blob/2.x/README.md
Deutsch: https://github.com/placer-toolkit/placer-style-guide/blob/2.x/translations/de/README.de.md
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Thanks for the awesome review again @randomguy-2650 🙌 |
Co-authored-by: randomguy-2650 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everyone basically chose “Startseite” in the Discord poll, so I’d update it here.
And I wouldn’t think any other option would get more votes anyways, so I’ll close that poll now.
Co-authored-by: randomguy-2650 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last changes, then we can merge 🙌
Do we (@randomguy-2650 @louisescher ) want to standardize all the different discussed translations in the whole tutorial PR (#12502 ) or here directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some “request change” comments here and there, some are just inclusivity (of operating systems?) and removal of useless dumb empty lines.
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Update with changes from #12532 |
I just requested the review from you again @randomguy-2650 since I answered some suggestions and also I am not entirely sure how to best translate the "Ctrl + C" thingy... |
Co-authored-by: randomguy-2650 <[email protected]>
Friendly reminder of a Hacktoberfest contribution 🥳 |
Description
Translate all pages of section 5 of the Astro Tutorial into German.
Merging into
de/tutorial
and when all tutorial pages are translated, merging this branch intomain
👍Note
Hacktoberfest participation please!
Related PRs