Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(de): Translate all files into German #771

Merged
merged 111 commits into from
Oct 26, 2023
Merged

i18n(de): Translate all files into German #771

merged 111 commits into from
Oct 26, 2023

Conversation

trueberryless
Copy link
Contributor

@trueberryless trueberryless commented Sep 27, 2023

What kind of changes does this PR include?

  • Changes or translations of Starlight docs site content

Description

  • Translate some pages of the docs into German because it was outdated.
  • Translate new pages of the docs into German
  • Translation for sidebar completed

List of translated pages

updated:

  • getting-started.mdx
  • index.mdx

new:

  • environmental-impact.md
  • guides/authoring-content.md
  • guides/components.md
  • guides/css-and-tailwind.md
  • guides/customization.md
  • guides/i18n.md
  • guides/overriding-components.md
  • guides/project-structure.md
  • guides/sidebar.md
  • reference/configuration.md
  • reference/frontmatter.md
  • reference/overrides.md
  • showcase.md

Link to translation overview: https://i18n.starlight.astro.build/

#hacktoberfest

@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2023

⚠️ No Changeset found

Latest commit: 600176e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Sep 27, 2023

👷 Deploy Preview for astro-starlight processing.

Name Link
🔨 Latest commit 600176e
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/653a3909ca47ee0008e94e0c

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Sep 27, 2023
@trueberryless trueberryless changed the title i18n(de): Translate index.mdx in the docs into German i18n(de): Translate index.mdx and getting-started.mdx in the docs into German Sep 27, 2023
@trueberryless trueberryless changed the title i18n(de): Translate index.mdx and getting-started.mdx in the docs into German i18n(de): Translate index.mdx, getting-started.mdx and reference/configuration.md in the docs into German Sep 27, 2023
@trueberryless trueberryless changed the title i18n(de): Translate index.mdx, getting-started.mdx and reference/configuration.md in the docs into German i18n(de): Translate index.mdx, getting-started.mdx, reference/configuration.md and reference/frontmatter.md in the docs into German Sep 27, 2023
@trueberryless trueberryless changed the title i18n(de): Translate index.mdx, getting-started.mdx, reference/configuration.md and reference/frontmatter.md in the docs into German i18n(de): Translate some files into German Sep 27, 2023
@trueberryless
Copy link
Contributor Author

trueberryless commented Sep 27, 2023

Okay, I gotta admit, I kinda messed up last 4 commits...
Should I just leave them, as they are or is there a possibility to revert them?

@HiDeoo
Copy link
Member

HiDeoo commented Sep 27, 2023

Okay, I gotta admit, I kinda messed up last 4 commits...

Do not worry, no problem at all.

When accepting your pull request, all your commits will be squashed into one just like if it was only one commit. So you can just leave them as they are, revert them if your prefer, add more commits, etc. What matters is the final result that will be merged into the main branch so if the content is good, the commits to get there do not really matter.

@trueberryless trueberryless marked this pull request as draft September 28, 2023 13:23
@trueberryless
Copy link
Contributor Author

trueberryless commented Sep 28, 2023

Okay, a few things about the last commit:

  • I'm not sure how to translate "Tailwind’s border utility classes" into German (currently it's: "die Grenznutzungsklassen von Tailwind")
  • more important: I added some   (forces space) to the preview of the theme-designer because I think it looks better if the sentences have a space after ending dot of the sentence... (I don't know if this design is intentional, but I though I will fix it)

If it is intentional that the preview has no spaces between sentences, I will revert my changes.

@trueberryless
Copy link
Contributor Author

Muss ich jetzt irgendwo nen Button klicken, damit der Branch gemerged werden könnte, weil er currently blockiert ist?

@trueberryless trueberryless changed the title i18n(de): Translate some files into German i18n(de): Translate all files into German Oct 26, 2023
@trueberryless
Copy link
Contributor Author

Finally, all files translated (again)! It would be really nice if the PR could count for #Hacktoberfest, but there is probably not enough time to review all files, so I'm not at all disappointed, if the PR is not merged in October...

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wir sind fast da! Hoffentlich schaffen wir das in Oktober noch zu mergen.

docs/src/content/docs/de/guides/authoring-content.md Outdated Show resolved Hide resolved
docs/src/content/docs/de/guides/overriding-components.md Outdated Show resolved Hide resolved
docs/src/content/docs/de/guides/overriding-components.md Outdated Show resolved Hide resolved
docs/src/content/docs/de/guides/overriding-components.md Outdated Show resolved Hide resolved
docs/src/content/docs/de/guides/overriding-components.md Outdated Show resolved Hide resolved
docs/src/content/docs/de/reference/overrides.md Outdated Show resolved Hide resolved
docs/src/content/docs/de/reference/overrides.md Outdated Show resolved Hide resolved
docs/src/content/docs/de/reference/overrides.md Outdated Show resolved Hide resolved
docs/src/content/docs/de/reference/overrides.md Outdated Show resolved Hide resolved
docs/src/content/docs/de/reference/overrides.md Outdated Show resolved Hide resolved
@delucis delucis added the hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest label Oct 26, 2023
@trueberryless
Copy link
Contributor Author

You love to see it:

image

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for all the hard work keeping this PR updated until it was fully reviewed 💖

@delucis delucis merged commit 3ae7936 into withastro:main Oct 26, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 docs Documentation website changes hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest i18n Anything to do with internationalization & translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants