Apply activation changes #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tommytrg
reviewed
Apr 10, 2025
app.vue
Outdated
| const { data, refresh } = await useFetch("/api/staking") | ||
| const { data, refresh } = await useLazyAsyncData('data-stamp-driver', async () => { | ||
| return await Promise.all([$fetch('/api/staking'), $fetch(`${EXPLORER_API}/network/supply?key=current_supply`)]) |
Member
There was a problem hiding this comment.
Can we move this logic to the server API to enable caching and avoid redundant calls to the block explorer? Also, I'd suggest not using useLazyAsyncData for a single call — the block explorer and RPC may have different response times, so we can display partial data while waiting for the rest to load
Tommytrg
reviewed
Apr 10, 2025
Tommytrg
reviewed
Apr 10, 2025
Tommytrg
reviewed
Apr 10, 2025
Tommytrg
reviewed
Apr 10, 2025
Tommytrg
reviewed
Apr 11, 2025
types.ts
Outdated
| amount: number | ||
| withdrawer: string, | ||
| } | ||
| export enum CallName { |
Member
There was a problem hiding this comment.
Suggested change
| export enum CallName { | |
| export enum RouteName { |
Tommytrg
reviewed
Apr 11, 2025
app.vue
Outdated
Comment on lines
45
to
46
| const { data: staking, refresh: refreshStaking } = await useFetch('/api/staking'); | ||
| const { data: supply, refresh: refreshSupply } = await useFetch('/api/supply'); |
Member
There was a problem hiding this comment.
Suggested change
| const { data: staking, refresh: refreshStaking } = await useFetch('/api/staking'); | |
| const { data: supply, refresh: refreshSupply } = await useFetch('/api/supply'); | |
| const { data: staking, refresh: refreshStaking } = await useFetch('/api/staking') | |
| const { data: supply, refresh: refreshSupply } = await useFetch('/api/supply') |
gabaldon
force-pushed
the
feat/apply-activation-changes
branch
from
814d15e to
ca4f77e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4